1125975 - KidFox: Restricted profiles - Hide other non-essential Settings items - All “Display” menu items

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1125975-settings-display.patch

Comment 2

[:Margaret Leibovic]

Comment on attachment 8640481 [details] [diff] [review]
1125975-settings-display.patch

Review of attachment 8640481 [details] [diff] [review]:
-----------------------------------------------------------------

Side note: is there a bug filed about disabling loading about:config?

::: mobile/android/base/restrictions/Restriction.java
@@ +92,5 @@
> +
> +    DISALLOW_DISPLAY_SETTINGS(
> +            18, "no_display_settings",
> +            R.string.restriction_disallow_display_settings_title,
> +            R.string.restriction_disallow_display_settings_description

Same question here about nsIParentalControlsService.idl.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Margaret Leibovic from comment #2)
> Side note: is there a bug filed about disabling loading about:config?

Oh. Very good point. I filed bug 1189233.


(In reply to :Margaret Leibovic from comment #2)
> Same question here about nsIParentalControlsService.idl.

... updating patch.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1125975-settings-display-v2.patch

Updated patch addressing review comments.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

url:        https://hg.mozilla.org/integration/fx-team/rev/2c9eadcc613aa5216226813cb22403a26126df90
changeset:  2c9eadcc613aa5216226813cb22403a26126df90
user:       Sebastian Kaspari <[e-mail]>
date:       Fri Jul 31 09:45:40 2015 +0200
description:
Bug 1125975 - Restricted profiles: Hide display settings. r=margaret

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c9eadcc613a

Comment 7

[u549602]

Verified as fixed on latest Aurora