Closed Bug 1197721 Opened 4 years ago Closed 4 years ago

KidFox: Restricted profiles - “Display” menu items are not hidden on Nexus 7 (5.1.1)

Categories

(Firefox for Android :: Profile Handling, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 43
Tracking Status
firefox42 --- verified
firefox43 --- verified

People

(Reporter: csuciu, Assigned: sebastian)

References

Details

Attachments

(1 file)

Nexus 7 (5.1.1) - “Display” menu items are not hidden on restricted profiles when 'Owner' disables 'Display settings'

This might be specific to this device because I couldn't reproduce on Sony Xperia Z2 10" with Android 5.0.2 and Nexus 9 with Android 5.1.1
@Catalin: I can reproduce on a Nexus 7 (2012). It seems like we are not using the spit pane settings on this device and we are not hiding the item in the normal settings list. This might affect more restrictions. We should test all of them on a Nexus 7.
Assignee: nobody → s.kaspari
Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh
Attachment #8654035 - Flags: review?(mhaigh)
Status: NEW → ASSIGNED
Attachment #8654035 - Flags: review?(mhaigh) → review+
Comment on attachment 8654035 [details]
MozReview Request: Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

https://reviewboard.mozilla.org/r/17589/#review15987
Comment on attachment 8654035 [details]
MozReview Request: Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

Approval Request Comment
[Feature/regressing bug #]: Bug 125975: KidFox: Restricted profiles - Hide other non-essential Settings items - All “Display” menu items (KidFox is targeting Fx42)
[User impact if declined]: Hidden setting is still visible on small (~7") tablets.
[Describe test coverage new/current, TreeHerder]: Manual testing. No UI test support for restricted profiles yet.
[Risks and why]: On small tablets we are using a different layout and the patch hides the setting in this layout too. Low risk.
[String/UUID change made/needed]: -
Attachment #8654035 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/b4ca0600cbe1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Verifying as fixed on latest Nightly
Status: RESOLVED → VERIFIED
Comment on attachment 8654035 [details]
MozReview Request: Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

New feature, we want to polish it, taking this patch.
Attachment #8654035 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verifying as fixed on latest Aurora.
You need to log in before you can comment on or make changes to this bug.