1197721 - KidFox: Restricted profiles - “Display” menu items are not hidden on Nexus 7 (5.1.1)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Catalin Suciu [:csuciu]]

Nexus 7 (5.1.1) - “Display” menu items are not hidden on restricted profiles when 'Owner' disables 'Display settings'

This might be specific to this device because I couldn't reproduce on Sony Xperia Z2 10" with Android 5.0.2 and Nexus 9 with Android 5.1.1

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

@Catalin: I can reproduce on a Nexus 7 (2012). It seems like we are not using the spit pane settings on this device and we are not hiding the item in the normal settings list. This might affect more restrictions. We should test all of them on a Nexus 7.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

Comment 3

[Martyn Haigh (:mhaigh)]

Comment on attachment 8654035 [details]
MozReview Request: Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

https://reviewboard.mozilla.org/r/17589/#review15987

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b4ca0600cbe1

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8654035 [details]
MozReview Request: Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

Approval Request Comment
[Feature/regressing bug #]: Bug 125975: KidFox: Restricted profiles - Hide other non-essential Settings items - All “Display” menu items (KidFox is targeting Fx42)
[User impact if declined]: Hidden setting is still visible on small (~7") tablets.
[Describe test coverage new/current, TreeHerder]: Manual testing. No UI test support for restricted profiles yet.
[Risks and why]: On small tablets we are using a different layout and the patch hides the setting in this layout too. Low risk.
[String/UUID change made/needed]: -

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b4ca0600cbe1

Comment 7

[Catalin Suciu [:csuciu]]

Verifying as fixed on latest Nightly

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8654035 [details]
MozReview Request: Bug 1197721 - Restricted profiles: Hide "Display" menu items in non-"split pane" settings list too. r?mhaigh

New feature, we want to polish it, taking this patch.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5fdfd34cc99f

Comment 10

[u549602]

Verifying as fixed on latest Aurora.