1126022 - [Wallpaper][Text Selection] Long pressing a wallpaper selects them all and causes the blue text selection carets/bubbles to appear when selecting a wallpaper.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Wallpaper, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150126_1410.txt

Description:
When in the gallery of wallpapers, if you long-press on one, they all become selected. A blue text selection caret will appear that you can manipulate/move around to change the selection box surrounding all the wallpapers. This issue is visual only, no functionality seems to be broken with this and 

Repro Steps:
1) Update a Flame to 20150126010231
2) Long press on an open area of the homescreen 
3) Select Change Wallpaper
4) Select Wallpaper
5) Long press on a wallpaper selection

Actual:
All wallpapers are selected - blue caret appears below 1st box / picture

Expected:
Text Selection functionality will not be present in the wallpaper picker. Long press will not have any function / will not select all

Environmental Variables:
Device: Flame 3.0 (KK - Nightly - OTA)
Build ID: 20150126010231
Gaia: 0f662dffef27599443cfcd790c2b39190a2b35c8
Gecko: fa91879c8428
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Repro frequency: 6/6
See attached: logcat, video: http://youtu.be/Qp8yS_Lhe4A

-------------------------------------------------------------------------------------

This issue also reproduces in Flame 2.2 (KK - nightly - full flashed)
Text Selection was introduced in 2.2 so this issue is not (would not be present) in 2.1 or earlier

Device: Flame 2.2 (KK - Nightly - Full Flash)
Build ID: 20150122002808
Gaia: e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko: 4a90da67661e
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 1

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 2

[Gerry Chang [:gchang]]

I can also recreate this issue. CC developers for investigation.

Comment 3

[Gerry Chang [:gchang]]

Attachment: Screenshot from 2015-01-29 11:40:25.png

Attach the image of showing carets in wallpaper.

Comment 4

[howie [:howie]]

broken new feature nominated as 2.2?

Comment 5

[Hema Koka [:hema]]

AFAIK, there were no text selection changes (including disabling it) done for wallpaper. It was not in the prioritized list for 2.2 text selection bugs. Why is this nominated as broken feature blocker -- there is no functionality broken for wallpaper as stated in the original description.

Punam, 

Take a look at it after any 2.2 blockers that you can help fix. 

Thanks
Hema

Comment 6

[howie [:howie]]

Hi Hema, 

You are right...I just check the Gaia 2.2 copy paste work bug 1092944 and wallpaper wasn't there, it actually should be but I missed it, sorry about that.

Still, I'd say this bug should be fixed since the caret showing isn't expected behavior.

Thank you all for the help.

Comment 7

[GitHub Autolander Bot]

Attachment: [PullReq] punamdahiya:Bug1126022 to mozilla-b2g:master

Comment 8

[Punam Dahiya [:pdahiya]]

Comment on attachment 8560626 [details] [review]
[PullReq] punamdahiya:Bug1126022 to mozilla-b2g:master

Hi David
Please review attached patch which by default disables user text selection for wallpaper app. Thanks!

Comment 9

[David Flanagan [:djf]]

Comment on attachment 8560626 [details] [review]
[PullReq] punamdahiya:Bug1126022 to mozilla-b2g:master

Looks good to me, though I did not test it.
Please nominate for 2.2 uplift once you have landed this.

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/dce54b7529f6660d52271a5d3b70582b6a12ee8a

Comment 11

[Punam Dahiya [:pdahiya]]

Comment on attachment 8560626 [details] [review]
[PullReq] punamdahiya:Bug1126022 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not a Regression
[User impact] if declined: Long press on one of the wallpaper selects all the wallpapers.
[Testing completed]:On master
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/be274f1b1f283853f0c3afe6eb65d39ccbe20f44

Comment 13

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: Long pressing on a wallpaper does not have any function. 
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150319010201
Gaia: c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gecko: cf1060d8ce9f
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150319002500
Gaia: 9043c11f699c15bb6072422d1dad6518d1b5ddda
Gecko: c0442d170bec
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0