Turn on screen sharing in nightly builds

RESOLVED FIXED in Firefox 38

Status

Hello (Loop)
Client
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla38
Points:
2
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
We should turn on screen sharing when:

- We've fixed the dependencies
- We're happy with the UX
- The link-clicker UI has been deployed
Priority: -- → P1
Depends on: 1130356

Updated

3 years ago
backlog: --- → Fx38+
(Assignee)

Comment 1

3 years ago
Created attachment 8563312 [details] [diff] [review]
Enable screen sharing for Loop link-generators by default.

I think with the change of the icon, its reasonable to enable this in nightly now. Bug 1130356 is the only other issue we might want to wait for, but I think its good enough for nightly users that we can enable without that (although hopefully it'll land soon).

Mike, what do you think? If not, we can just hold this patch until we're ready.
Attachment #8563312 - Flags: review?(mdeboer)
(Assignee)

Updated

3 years ago
Assignee: nobody → standard8
Iteration: --- → 38.3 - 23 Feb
Points: --- → 1
Comment on attachment 8563312 [details] [diff] [review]
Enable screen sharing for Loop link-generators by default.

We discussed on IRC that we'll just remove the pref altogether.
Attachment #8563312 - Flags: review?(mdeboer)
Points: 1 → 2
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8563357 [details] [diff] [review]
Enable screen sharing for Loop link-generators by default.

Updated patch to remove the preference completely.
Attachment #8563312 - Attachment is obsolete: true
Attachment #8563357 - Flags: review?(mdeboer)
Comment on attachment 8563357 [details] [diff] [review]
Enable screen sharing for Loop link-generators by default.

Review of attachment 8563357 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8563357 - Flags: review?(mdeboer) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/a68f15690f03
Target Milestone: --- → mozilla38
https://hg.mozilla.org/mozilla-central/rev/a68f15690f03
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.