1126289 - Turn on screen sharing in nightly builds

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

We should turn on screen sharing when:

- We've fixed the dependencies
- We're happy with the UX
- The link-clicker UI has been deployed

Comment 1

[Mark Banner (:standard8)]

Attachment: Enable screen sharing for Loop link-generators by default.

I think with the change of the icon, its reasonable to enable this in nightly now. Bug 1130356 is the only other issue we might want to wait for, but I think its good enough for nightly users that we can enable without that (although hopefully it'll land soon).

Mike, what do you think? If not, we can just hold this patch until we're ready.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8563312 [details] [diff] [review]
Enable screen sharing for Loop link-generators by default.

We discussed on IRC that we'll just remove the pref altogether.

Comment 3

[Mark Banner (:standard8)]

Attachment: Enable screen sharing for Loop link-generators by default.

Updated patch to remove the preference completely.

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8563357 [details] [diff] [review]
Enable screen sharing for Loop link-generators by default.

Review of attachment 8563357 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/a68f15690f03

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a68f15690f03