1126297 - Add page title when sharing a page to Twitter

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Dripple]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150122214805

Steps to reproduce:

Share a page to Twitter using the Share button


Actual results:

URL is prefilled but not page title


Expected results:

Page title should alson have been included

Comment 1

[Aaron Train [:aaronmt]]

We do specify adding a title/extra title, but I believe it's up to the receiver app to decide what to do with it. Correct?

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoAppShell.java?from=GeckoAppShell.java#1137

Comment 2

[Richard Newman [:rnewman]]

Yes: indeed, we put the title twice!

If the reporter can suggest a method that Twitter picks up correctly, we can look into this further. Otherwise, this doesn't seem to be our bug.

Comment 3

[Dripple]

Attachment: Screenshot - Sharing a link from Firefox to Twitter - URL present but no title

Comment 4

[Dripple]

OK, will try from the Twitter side.

Comment 5

[Dripple]

OK, I guess that we should put either URL & content in Intent.EXTRA_TEXT

shareIntent.putExtra(Intent.EXTRA_TEXT, title + " - " + targetURI);

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that this should behave same as Firefox for Desktop. See bug 1103104.

mcomella: Are you the owner of this part? If so, could you check this?

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #6)
> mcomella: Are you the owner of this part? If so, could you check this?

More or less.

(In reply to Dripple from comment #5)
> OK, I guess that we should put either URL & content in Intent.EXTRA_TEXT
> 
> shareIntent.putExtra(Intent.EXTRA_TEXT, title + " - " + targetURI);

Seems we currently only put the uri in EXTRA_TEXT [1]. I'll check it out.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoAppShell.java?rev=c72acc2daca6#1109

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It's worth noting that Chrome does not have the behavior desired in comment 0 so we're going to diverge. I'm not sure the side effects of sharing to other apps by adding the title to EXTRA_TEXT.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1126297 - (WIP) Set extra text to "title - uri" on share intents.

Bug 1126297 - (WIP) Set extra text to "title - uri" on share intents.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Dripple from comment #5)
> OK, I guess that we should put either URL & content in Intent.EXTRA_TEXT
> 
> shareIntent.putExtra(Intent.EXTRA_TEXT, title + " - " + targetURI);

I built this with the WIP in comment 9 but it doesn't work as expected. I imagine this is because Twitter uses the "data" field of the intent, which must be a URI. Thus I don't think we have control over the content Twitter displays when we share (and I'm thinking RESOLVED - INVALID).

Dripple, how did you come up with the above solution from comment 5? Have you seen this approach work?

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Going to INVALID and reopen if Dripple comes up with an appropriate solution.