1103104 - support title for twitter share

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Due to the way some providers have both title and text support in share, and twitter only has text support, text is only inserted into twitter share if the user has selected some text in the page.  Should examine providing page title if there is no text selection, but need to be careful to not duplicate title/text for other providers.  Something like this might work:

if selection-argument in shareurl and 
   title-argument not in shareurl and no selection
  selection = title

Comment 1

[Shane Caraveo (:mixedpuppy)]

This change would be in OpenGraphBuilder.generateEndpointURL in Social.jsm.  Need to add something like:

if (p[1] == "text" && "%{title}".indexOf(queryString) < 0) {
  if (!pageData.text && pageData.title)
     query["text"] = pageData.title;
}

Comment 3

[:Gijs (out for now; he/him)]

Can this be a good first / mentored bug with you as a mentor, Shane? :-)

Comment 4

[Paul [pwd]]

I'm wondering if the code from Fennec could be used?

Comment 5

[Daniele "Mte90" Scasciafratte]

Very annoying the missing of the title page in the tweet :-/

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: support title in text fields for share providers

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa1105ad89ce

Comment 7

[:Gijs (out for now; he/him)]

Comment on attachment 8574965 [details] [diff] [review]
support title in text fields for share providers

Review of attachment 8574965 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/Social.jsm
@@ +520,5 @@
>          }
>        });
> +      // if the url template doesn't have title and no text was provided, add the title as the text.
> +      if (!query.text && !query.title && pageData.title) {
> +        query["text"] = pageData.title;

Nit: query.text =

Comment 8

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/fx-team/rev/e3e2dfaf9037

Comment 9

[Shane Caraveo (:mixedpuppy)]

Attachment: support title in text fields for share providers

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e3e2dfaf9037