fatal (debug-build) assertion with width:-moz-max-content in vertical writing mode

RESOLVED FIXED in mozilla38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Created attachment 8555388 [details]
testcase -- fatally asserts in debug build

The patch for bug 1122366 means that in vertical writing mode, nsBlockFrame::IsSelfEmpty will be passing width coords (instead of height) to IsNonAutoNonZeroHeight(), and these may include things like -moz-max-content that it is not prepared to handle.

This is similar to the assertion we had in bug 1113216, and I propose to wallpaper it in the same way for now, treating enumerated values for block-size as if they were 'auto' for the purposes of this check.

IsNonAutoNonZeroHeight() is only used by nsBlockFrame::IsSelfEmpty, so the worst that will happen as a result of this is that we'll sometimes incorrectly consider a block to be empty (e.g. if it has width:-moz-available), and we might therefore collapse margins in a case where we shouldn't.
(Assignee)

Comment 1

4 years ago
Created attachment 8555391 [details] [diff] [review]
Don't assert when intrinsic size values are used for a block-size property, just pretend they're 'auto' for now
Attachment #8555391 - Flags: review?(dbaron)
(Assignee)

Updated

4 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8555391 [details] [diff] [review]
Don't assert when intrinsic size values are used for a block-size property, just pretend they're 'auto' for now

r=dbaron.

Maybe add a comment pointing this out in relevant bugs?  (perhaps the ones in the comment?)
Attachment #8555391 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/31e36157db00
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.