Closed Bug 1126484 Opened 11 years ago Closed 11 years ago

Reader Mode should use the right fonts

Categories

(Firefox for iOS :: Reader View, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: st3fan, Assigned: st3fan)

References

Details

Attachments

(1 file)

We should use Fira Sans and Charis SIL. The first is somewhat included in the app already and the latter is completely missing. Both font families need to be complete enough for the CSS that Reader Mode uses. The CSS also needs to be modified to use those two fonts. (Or maybe we do this programatically, check the android reader code to be sure)
This patch makes the following changes: Include Fira Sans and Charis SIL in the application - currently we include all variants. I'll file a followup bug to narrow down our included fonts. Change the Reader.css to use Fira Sans and Charis SIL Change the ReaderMode.js to patch the relative font sources from the CSS into full URLs that point to our embedded server. Font loading from the embedded server works great and fast. I see no noticable delays when enabling Reader Mode.
Attachment #8556635 - Flags: review?(bnicholson)
Attachment #8556635 - Flags: review?(bnicholson) → review+
Squashed and Merged.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: