1126494 - Disable theme-color when in private browsing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Kevin Grandon :kgrandon]

Since we're currently relying on the theme color to indicate private browsing, we should disable the theme-color meta tag from working when in a private browsing context. Alternatively we could change the menu icon to the mask perhaps? Then we probably wouldn't need to disable it.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1126494_disable_theme_color_private_window to mozilla-b2g:master

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1126494_disable_theme_color_private_window to mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8555608 [details] [review]
[PullReq] KevinGrandon:bug_1126494_disable_theme_color_private_window to mozilla-b2g:master

Etienne - could you take a look here? We might change this in the future, but I think this makes the most sense for now.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8555608 [details] [review]
[PullReq] KevinGrandon:bug_1126494_disable_theme_color_private_window to mozilla-b2g:master

makes sense

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/47dbdb08fb298b48953e3cce09eefc34c50ff819

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8555608 [details] [review]
[PullReq] KevinGrandon:bug_1126494_disable_theme_color_private_window to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Possible confusion when navigating to a site with theme-color and private browsing. We may bring back theme-color in the future, but we would first need a different UX for private browsing.
[Testing completed]: Manual and unit test.
[Risk to taking this patch] (and alternatives if risky): Small, contained patch. Low risk.
[String changes made]: No.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/7916abb0946a132a0857a0e7afb24b8091fafcd8

Comment 8

[Jessica]

Attachment: verified_Flame v2.2.3gp

This bug has been verified as pass on latest Nightly Flame v2.2 & master.

STR:
1.Launch browser app.
2.Tap "new private window".
3.Put in any website in search bar, eg:www.sina.com.
4.Tap search button and enter the page.

Actual results: Theme-color is enabled and available in private browsing.
See attachment: verified_Flame v2.2.3gp
Reproduce rate: 0/6


Device: Flame 2.2 (Pass)
Build ID               20150723002503
Gaia Revision          e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gaia Date              2015-07-15 21:05:11
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d8326043baec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150723.041700
Firmware Date          Thu Jul 23 04:17:12 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Pass)
Build ID               20150723160204
Gaia Revision          ec2199b324304d3678b6a98a08a31bdc13c9e984
Gaia Date              2015-07-23 17:16:25
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cb8bdb8ffaef
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150723.193607
Firmware Date          Thu Jul 23 19:36:19 EDT 2015
Bootloader             L1TC000118D0