Closed Bug 1126542 Opened 10 years ago Closed 10 years ago

Use mock server for SearchTests search suggestions

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Pull request
47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
Instead of firing real HTTP requests to real search engines.
Attached file Pull request —
Attachment #8555511 - Flags: review?(sarentz)
Comment on attachment 8555511 [details] [review] Pull request This looks good. Excellent test. And, I totally agree with your composition over inheritance comment. Lets write a few more tests that need a web server and then we will probably have a good idea of what functionality can go into some helper class or functions.
Attachment #8555511 - Flags: review?(sarentz) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: