1126584 - Support signing in to Firefox Account via embedding accounts.firefox.com

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, defect)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks embedding accounts.firefox.com into the iOS app and implementing (enough of) the Sync postMessage protocol to pass Firefox Account credentials back to Swift.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/117

Hey peeps, here's a first experiment at embedding the FxA sign in flow into Firefox for iOS.  I glued it in to an existing button in settings, just for testing.

The patch shows an interstitial loading/error page which is replaced with the background loaded webview.  If you log in with a valid FxA (pointing at dev servers right now, you may need to make a new account) you'll see the settings UI update the email address.  There's no persistence yet.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8555573 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/117

I added a bunch of notes to the PR. Some of it is just Swift code style stuff.

But there are also some bigger questons about how things talk to eachother.

I +'d this patch because I don't want to hold this up but I do think we should at least chat about some of the bigger points. They can also be followup refactoring bugs.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8555573 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/117

Sorry for the late review. Looks pretty good to me.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla/firefox-ios/commit/c7b48fa9dde51c8be25f814cc631418f88435f11