1126591 - Put packaged (iframe) app on 2.2 and master

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[David Durst [:ddurst]]

Gaia's master and 2.2 have a marketplace package that's pretty old. We need to update it with the current one, which has the proper permissions added for feature detection (at least).

I assume dev and stage apps should also be updated.

Process reference: http://marketplace.readthedocs.org/en/latest/topics/packaged-apps.html

See a similar history here: bug 1038350

Comment 1

[Mathieu Pillard [:mat]]

Attachment: gaia pull request for prod package (master)

Comment 2

[Mathieu Pillard [:mat]]

Wil, can you build new stage & dev packages and push them to mkt-stage and mkt-dev ? That way I'll also update those in gaia.

Comment 3

[Wil Clouser [:clouserw]]

You bet.

https://marketplace.firefox.com/app/mkt-dev/
https://marketplace.firefox.com/app/mkt-stage/

You don't need me to do prod?

Comment 4

[Mathieu Pillard [:mat]]

A fresh prod packaged was already built on the 12th December, no need to make a new one. Thanks!

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Comment on attachment 8556470 [details] [review]
gaia pull request for prod package (master)

r=me

Looks good to me, provided try is green and you had reviews on the code separately.

Yet I wonder why you need the permissions "tcp-socket" and you'll need to take care that "moz-firefox-accounts" can be disabled by the user.

Comment 6

[Wil Clouser [:clouserw]]

Landed in https://github.com/mozilla-b2g/gaia/commit/cf277306be1fef2060f2d2335ea0b875524816ff for master.  Leaving bug open for 2.2

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Mathieu, please request an approval when you have time.

Comment 8

[Wil Clouser [:clouserw]]

Nominating for 2.2:

Bug/Feature:  This is adding support for feature detection to the Marketplace package (a new permission we need to request in the manifest).

User impact if declined:  Users on 2.2 won't see apps in the Marketplace filtered for their device capabilities.

Testing completed:  Has gone through our regular test cycles.  Krupa Raj is our test lead and can expand on any questions there.

Risk to taking the patch (and alternatives):  Low risk as it's a minor change (adding a line to the manifest).

String or UUID changes: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Wil Clouser [:clouserw] from comment #6)
> Leaving bug open for 2.2

Please don't. Bugs get resolved when they landed on master. Status flags track uplifts. The bug queries we use for uplift tracking depend on that and bugs very easily slip through the cracks otherwise.
https://wiki.mozilla.org/Release_Management/B2G_Landing explains the process in better detail.

v2.2: https://github.com/mozilla-b2g/gaia/commit/d6b8f6fec923f42e50c8b31e5d10a84824f73e0d