1126850 - [RTL] "(Conference (2" is displayed when you're in a conference call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: Screenshot

Like in bug 1102344, "Conference (2)" displays "(Conference (2" when you have a conference call ongoing.

See screenshot

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] tamarahills:bugfix/1126850_rtl_conf_parens to mozilla-b2g:master

Comment 2

[Tamara Hills [:thills]]

Attachment: PR for fix

Comment 3

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8558127 [details] [review]
PR for fix

Looks good to me!

Comment 4

[Tamara Hills [:thills]]

https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=c39944d72d27

https://github.com/mozilla-b2g/gaia/commit/1e2c128e1343668fe0ef7f8e48bf6cb60280dd19

Comment 5

[Tamara Hills [:thills]]

NI to myself to ask for uplift.

Comment 6

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 3.0

String now appears as "Conference (2)" while in conference call.

Adding verifyme keyword to check 2.2 after uplift.

Device: Flame 3.0 Master
Build ID: 20150205010209
Gaia: 1e2c128e1343668fe0ef7f8e48bf6cb60280dd19
Gecko: 34a66aaaca81
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 7

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:

https://moztrap.mozilla.org/manage/case/15515/

Comment 8

[Tamara Hills [:thills]]

Attachment: 2.2 Uplift request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):It's a new feature to support RTL
[User impact] if declined: An RTL user would see the Conference(2) string in an incorrect format.  
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky):  Low.  
[String changes made]: No

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/777c88acde2dc130ccc83a962dca2092df056ffe

BTW, you can just put the approval request on the Pull Request attachment rather than creating a new attachment just for that.

Comment 10

[Tamara Hills [:thills]]

clearing NI

Comment 11

[Sue]

Attachment: 2015-02-26-14-31-51.png

This issue has been verified successfully on Flame v2.2, "Conference" displays as Arabic and shows at right side of "(2)" when you have a conference call ongoing.
See attachment:2015-02-26-14-31-51.png
Rate:0/5

Flame 2.2 build:
Build ID               20150225002505
Gaia Revision          ca64f2fe145909f31af266b1730874051ba76c78
Gaia Date              2015-02-24 22:06:53
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.041814
Firmware Date          Wed Feb 25 04:18:25 EST 2015
Bootloader             L1TC000118D0