1126964 - Rocketbar background flashes when entering the search app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Kevin Grandon :kgrandon]

Probably also caused by Bug 1117968, currently when you enter rocketbar there is a distracting flash. It's not clear if bug 1125810 will resolve this, but I'm filing another bug to track it at least until it's fixed.

STR:
1- Tap rocketbar on home screen.

Expected result:
The input background will not flash.

Actual result:
The input background flashes.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] daleharvey:1126964 to mozilla-b2g:master

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] daleharvey:1126964 to mozilla-b2g:master

Comment 3

[Dale Harvey (:daleharvey)]

Comment on attachment 8560907 [details] [review]
[PullReq] daleharvey:1126964 to mozilla-b2g:master

This fixes a few small layout issues that were too much to be split into seperate patches, main ones are

1. Open transition, should fade in when results start showing, background should be darker
2. Position of offline message
3. Padding between the shown headings
4. Border below the places results (the border has padding but the active background shouldnt

Visuals to check against are @ https://mozilla.app.box.com/s/gpijv051aeivyoxcz72a

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8560908 [details] [review]
[PullReq] daleharvey:1126964 to mozilla-b2g:master

I have no idea why this attached twice. Need to look into that.

Comment 5

[Dale Harvey (:daleharvey)]

I closed and reopened it, may be why

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8560907 [details] [review]
[PullReq] daleharvey:1126964 to mozilla-b2g:master

This is looking much more polished, nice work!

Comment 7

[Dale Harvey (:daleharvey)]

Awesome thanks, landed in https://github.com/mozilla-b2g/gaia/commit/be3a2109d78207e5cfae3ec4597b598dc827a96c

Gregor also feature 2.2

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 8560907 [details] [review]
[PullReq] daleharvey:1126964 to mozilla-b2g:master

Clearing review

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

Adding qawanted for verification.

Comment 11

[Dale Harvey (:daleharvey)]

Pushed to 2.2 in https://github.com/mozilla-b2g/gaia/commit/7e565d0259cc3d4e41eefed8ffa7bea067c65c78

Green try run @ https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=4a6c9879b64e

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame 3.0. Rocketbar search field no longer flashes upon enabling it via Homescreen.

The duped bug 1131049 is also verified fixed. Background appears translucent when enabling Rocketbar search.

I noticed that as soon as I typed a letter into Rocketbar, background becomes opaque gray again. I read the user story on bug 1125810 ( https://mozilla.app.box.com/s/gpijv051aeivyoxcz72a ), it seems to be an expected behavior.

Tested on:
Device: Flame 3.0 (full flash)
BuildID: 20150209133005
Gaia: 0cf517083f7eb5fc269e1236edba50534f65e3cd
Gecko: 1af029247ca5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

-----

Since 2.2 has just been uplifted, we need to wait til tomorrow for a build that contains the fix. Leaving verifyme keyword for 2.2 verify.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Did this get approval for uplift somewhere outside the bug?

Comment 14

[Dale Harvey (:daleharvey)]

> Did this get approval for uplift somewhere outside the bug?

Its feature-b2g 2.2+, do we need seperate approval to land 2.2+'d feature work before FC?

Comment 15

[Ryan VanderMeulen [:RyanVM]]

The policy is the same as it has always been. *All* patches require approval regardless of status. It's also clearly spelled out on the B2G Landing wiki.

Comment 16

[Dale Harvey (:daleharvey)]

Comment on attachment 8560907 [details] [review]
[PullReq] daleharvey:1126964 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 2.2 Feature Development, accidentally already landed without approval, proactively asking for approval
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 17

[Shally Li（leave from Mozilla）]

Per Comment 12, this bug has been successfully verified on latest Flame v2.2.

See attachment: verified_v2.2.mp4.
Reproduce rate: 0/5.

STR:
1. Tap Rocketbar on homescreen.
**Rocketbar search field no longer flashes.And background appears translucent.
2. Type a letter or dot (.) in Rocketbar.
**Background becomes opaque gray.

Flame 2.2 build:
Build ID               20150210002516
Gaia Revision          b30c8e4303595a0fcb5b640d673cf8503b954701
Gaia Date              2015-02-10 04:09:47
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3e9fa4e70a1b
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150210.041059
Firmware Date          Tue Feb 10 04:11:10 EST 2015
Bootloader             L1TC000118D0

Comment 18

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.MP4