Closed Bug 112715 Opened 23 years ago Closed 22 years ago

Implement HTML Radio button in XBL

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: bryner, Assigned: bryner)

References

Details

Attachments

(2 files, 2 obsolete files)

another new patch
7.75 KB, patch
pavlov
: review+
bugs
: superreview+
Details | Diff | Splinter Review
fix some major problems
4.44 KB, patch
john
: review+
asa
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
The HTML radiobutton control should be implemented in XBL using XUL radiobuttons.
Blocks: 57209
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
Depends on: 108308
Work on XBL form controls is ongoing in the tree, but will not be completed for
0.9.8.  -> 0.9.9.
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Keywords: nsbeta1+
XBL form controls will not be turned on for 0.9.9.  -> 1.0.
Target Milestone: mozilla0.9.9 → mozilla1.0
Keywords: mozilla1.0+
Closing out "Implement <blah> in XBL" bugs where we have an implementation
checked in that is enabled via the XBL form controls preference in the Debug
pref panel.  Please file any remaining issues as separate bugs.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Are you sure this is fixed?  Radio buttons in Bugzilla don't look anything like
the radio buttons in Prefs.
Oops, inadvertently closed this one out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
*** Bug 130003 has been marked as a duplicate of this bug. ***
Attached patch patch (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        new patch (obsolete)
        — 
          — Splinter Review
      

    


  
oops, forgot a file

        Attachment #75353 -
        Attachment is obsolete: true

    
    

    
  


  
oops, previous patch had a typo.

        Attachment #75354 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 75355 [details] [diff] [review]
another new patch

r=pavlov

        Attachment #75355 -
        Flags: review+

    
    

    
  


  
I missed some major problems with my last patch:

- I didn't suppress construction of the GfxRadioControlFrame, so the XBL widget
wasn't actually being used.

- Need to remove radio button rules in xbl-forms.css that were copied from
layout/html/document/src/forms.css.

- Need to import radio.css from layout/html/forms/resources/skin/forms.css

- Need to apply the XUL namespace to style rules for XUL elements in radio.css

    
    

    
  
Comment on attachment 75475 [details] [diff] [review]
fix some major problems

sr=jst

        Attachment #75475 -
        Flags: superreview+

    
    

    
  
Comment on attachment 75475 [details] [diff] [review]
fix some major problems

r=jkeiser

        Attachment #75475 -
        Flags: superreview+ → review+

    
    

    
  
Comment on attachment 75475 [details] [diff] [review]
fix some major problems

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

        Attachment #75475 -
        Flags: superreview+

        Attachment #75475 -
        Flags: approval+

    
    

    
  
Checked in.

Status: REOPENED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED

    
  
QA Contact: madhur → tpreston

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: