112724 - Remove duplicate copies of messenger's contents.rdf

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect)

Description

[Scott MacGregor]

I'm trying to remove all our extra copies of messenger's contents.rdf file to
reduce complexity and reduce regressions. Currently we have 4 copies of this
file and if you forget to change one of them you could break something =).

The 4 copies are:
1) mailnews\base\resources\content\contents.rdf (the primary copy)
2) mailnews\mapi\resources\content (mapi adds and overlay + everything in the
primary copy)
3) the commercial tree base\resources\content has one
4) the commercial tree mapi directory has one.

Bugscape Bug #11194 tracks 3 and 4. 

This patch is to remove (2) leaving us with just the one copy of contents.rdf
for the messenger package. 

To fix this, I recently discovered that we can create our own chrome packages
and put them in messenger.jar. A chrome package can have its own contents.rdf
file without sharing the one used by the messenger chrome space. 

For the simple mapi chrome, I called this new name space "messenger-mapi". So
all your chrome resources are now referenced as
"chrome://messenger-mapi/content/foo.xul"

Posting a patch to show what I did.

Comment 1

[Scott MacGregor]

Attachment: the fix

These changes create a new chrome package called "messenger-mapi". The
contents.rdf file for this new chrome package only has one overlay defined in
it. So I took out all the duplicate entries from messenger's contents.rdf. 

the mail.jst and langenus.jst changes are to make sure this new chrome package
gets registered as part of the packager for release builds.

Comment 2

[Scott MacGregor]

*** Bug 102560 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 59767 [details] [diff] [review]
the fix

sr=sspitzer

are the same changes going in for the ns tree?

Comment 4

[Scott MacGregor]

turns out srilatha is on vacation. I got a temporary r=bienvenu and when she
gets back I'll go over it with her to make sure she's okay with the changes to. 

Comment 5

[Scott MacGregor]

this has been checked in. 

Comment 6

[Trix Supremo]

verified on trunk 2002042510