Closed Bug 1127289 Opened 6 years ago Closed 5 years ago

DrawTargetTiled code paths in TiledContentClient is missing some of the synchronization code.

Categories

(Core :: Graphics: Layers, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED INVALID
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: nical, Assigned: nical)

References

Details

Attachments

(1 file)

This is most probably what's causing the R14 failure on the the emulator with DrawTargetTiled.
Blocks: 1071769
Attached patch PatchSplinter Review
Assignee: nobody → nical.bugzilla
Attachment #8556427 - Flags: review?(sotaro.ikeda.g)
nical, SyncObject derived class seems to exist only for D3D11. It is SyncObjectD3D11. Gralloc uses FenceHandle. How does the patch fix the problem for gralloc?
Flags: needinfo?(nical.bugzilla)
And emulator is run on ICS. ICS does not have sync object like android::Fence.
(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> nical, SyncObject derived class seems to exist only for D3D11. It is
> SyncObjectD3D11. Gralloc uses FenceHandle. How does the patch fix the
> problem for gralloc?

Darnit! I thought it was a gralloc thing. Well I guess it doesn't fix the issue, although we should still take this patch since this is still missing from the DrawTargetTiled code path.
Flags: needinfo?(nical.bugzilla)
Comment on attachment 8556427 [details] [diff] [review]
Patch

Review of attachment 8556427 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8556427 - Flags: review?(sotaro.ikeda.g) → review+
Summary: DrawTargetTiled code paths in TiledContentClient is missing some of the gralloc-specific synchronization. → DrawTargetTiled code paths in TiledContentClient is missing some of the synchronization code.
https://hg.mozilla.org/mozilla-central/rev/8a49d4f4bb25
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
So, is this the reason bug 1081349 et al are spiking again?
Flags: needinfo?(nical.bugzilla)
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #10)
> So, is this the reason bug 1081349 et al are spiking again?

This patch only affects windows under a configuration that we don't ship yet, so I don't think this can be the reason for bug 1081349 to spike again.
Flags: needinfo?(nical.bugzilla)
(In reply to Nicolas Silva [:nical] from comment #11)
> This patch only affects windows under a configuration that we don't ship
> yet, so I don't think this can be the reason for bug 1081349 to spike again.

Actually I take that back. It can also affect other platforms. digging.
The patch that landed in bug 1129360 caused Android reftest failures, so we've gone ahead and backed this out while they're being investigated.
https://hg.mozilla.org/integration/mozilla-inbound/rev/37321f61780e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla38 → ---
W.T.F.

The reftest failures that started on the push for bug 1129360 didn't go away when I backed it and this bug out! So I've relanded this bug on the hope that it makes the Android permafail go away, even if we're still stuck with with the B2G intermittents. *cry*

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d87dc37c707
Yup, re-landing this fix made the Android permafails go away. *sigh*
https://hg.mozilla.org/mozilla-central/rev/7d87dc37c707
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
See Also: → 1130681
Partial Backout - https://hg.mozilla.org/mozilla-central/rev/9cf76d4021ce
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See Also: → 1133484
The TiledCOntentClient code has changed a lot since, and I don't think this applies anymore.
Status: REOPENED → RESOLVED
Closed: 6 years ago5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.