1127457 - devicemanagerADB will never use zip/unzip

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Geoff Brown [:gbrown]]

In bug 1026710, this change was made:

     def _isLocalZipAvailable(self):
         try:
-            subprocess.check_call(["zip", "-?"], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+            self._checkCmd(["zip", "-?"])
         except:
             return False
         return True

Notice that instead of checking to see if zip is available locally, we now check to see if "adb zip" succeeds -- it never does. 

On the other hand, :wlach is/was considering removing zip/unzip entirely -- bug 1055221. On the other, other hand, I wonder if wlach's test in that bug was valid...was his test invalidated by this bug?

Comment 1

[William Lachance (:wlach)]

(In reply to Geoff Brown [:gbrown] from comment #0)
> In bug 1026710, this change was made:

> On the other hand, :wlach is/was considering removing zip/unzip entirely --
> bug 1055221. On the other, other hand, I wonder if wlach's test in that bug
> was valid...was his test invalidated by this bug?

Quite possible. :)

Comment 2

[Geoff Brown [:gbrown]]

Attachment: use ProcessHandler for zip verification

The zip optimization can save a few minutes when pushing the xpcshell tests directory, so I'd like to enable it when possible. 

_checkCmd() executes its arguments via adb -- not what we want here! I've just changed that to ProcessHandler, discarding the output; an exception is thrown and caught if zip is not available. Tested locally -- works great!

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a49d1a35f81

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5a49d1a35f81