Closed Bug 1127457 Opened 6 years ago Closed 6 years ago
ADB will never use zip/unzip
In bug 1026710, this change was made: def _isLocalZipAvailable(self): try: - subprocess.check_call(["zip", "-?"], stdout=subprocess.PIPE, stderr=subprocess.PIPE) + self._checkCmd(["zip", "-?"]) except: return False return True Notice that instead of checking to see if zip is available locally, we now check to see if "adb zip" succeeds -- it never does. On the other hand, :wlach is/was considering removing zip/unzip entirely -- bug 1055221. On the other, other hand, I wonder if wlach's test in that bug was valid...was his test invalidated by this bug?
Summary: devicemanagerADB will not use zip/unzip if zip is not available on device → devicemanagerADB will never use zip/unzip
(In reply to Geoff Brown [:gbrown] from comment #0) > In bug 1026710, this change was made: > On the other hand, :wlach is/was considering removing zip/unzip entirely -- > bug 1055221. On the other, other hand, I wonder if wlach's test in that bug > was valid...was his test invalidated by this bug? Quite possible. :)
The zip optimization can save a few minutes when pushing the xpcshell tests directory, so I'd like to enable it when possible. _checkCmd() executes its arguments via adb -- not what we want here! I've just changed that to ProcessHandler, discarding the output; an exception is thrown and caught if zip is not available. Tested locally -- works great!
Attachment #8556708 - Flags: review?(armenzg)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.