1127559 - [Dialer] End call button gets wider when putting a call on hold

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: End call larger Logcat

Description:
If the user is in a call and puts the call on hold, the end call button will get larger in size. If the user takes the call off hold, the end call button will return to its normal size


Repro Steps:
1) Update a Flame to 20150129010239
2) Establish a call on a device
3) Put the call on hold, and observe the end call button

Actual:
The end call button gets slightly larger in width

Expected:
The end call button remains the same size

Environmental Variables:
Device: Flame Master (319mb)(Kitkat)(Full Flash)
Build ID: 20150129010239
Gaia: 9d2378a9ef092ab1fc15c3a9f7fc4171aab59d57
Gecko: 6bfc0e1c4b29
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 10/10
See attached: Logcat, Video - http://youtu.be/bX6oeobVX_I

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This bug DOES occur on Flame 2.2

The end call button gets wider

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150127002504
Gaia: 80d5b797fd0497a7e3337b7798a21b2e1219681a
Gecko: 01bf1516a65b
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

_____________________________________________________________________________

This issue does not occur on Flame 2.1 because the Hold button ("||") did not exist.

Comment 2

[Eric Chang [:ericcc] [:echang]]

http://youtu.be/xnGHYBE1wKc
UI polish, suggest to out this in backlog, thanks.

Comment 3

[Doug Sherk (:drs) (inactive)]

Probably a regression from bug 977588.

Comment 4

[Atique Ahmed Ziad [:atiqueahmedziad]]

I am fixing it :)

Comment 5

[Atique Ahmed Ziad [:atiqueahmedziad]]

Need Details to fix it

Comment 6

[Doug Sherk (:drs) (inactive)]

Thanks for taking this bug.

I haven't investigated this, but I believe that the problem is probably somewhere here:
https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/style/oncall.css#L327-L336

If not, this is a good starting point. Another thing you could look into is how the '.held' class affects the styles, like this:
https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/style/oncall.css#L327-L336

Do you need anymore information?

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] atiqueahmedziad:019921 > mozilla-b2g:master

Comment 8

[Atique Ahmed Ziad [:atiqueahmedziad]]

Comment on attachment 8613283 [details] [review]
[gaia] atiqueahmedziad:019921 > mozilla-b2g:master

Sorry for late, as my previous device(keon) get hangs frequently in latest Gaia, couldn't work with that. But now got a new device :)
please review the pr :) Thanks for your help !

Comment 9

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8613283 [details] [review]
[gaia] atiqueahmedziad:019921 > mozilla-b2g:master

Unfortunately this solution has a drawback: with the patch applied the hang-up button becomes smaller when in RTL mode. This is because it breaks the rules introduced in bug 1106185. You'll have to be careful not to break the layout when in RTL mode.

Comment 10

[Atique Ahmed Ziad [:atiqueahmedziad]]

@gabriele: Will you please check the pr now ? :) 
I will squash the commits after cloning Gaia.

Comment 11

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8613283 [details] [review]
[gaia] atiqueahmedziad:019921 > mozilla-b2g:master

Still not good enough, now the button expands and contracts on both sides. I don't think that there's an issue with the padding for the specific button but rather for the top-level rule here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/style/oncall.css#L946

When a single call is on hold this selector fails and I suspect that's what causing the issue. Add another selector for the "connected-hold" data layout and see if it helps (w/o any other change).

Comment 12

[Atique Ahmed Ziad [:atiqueahmedziad]]

Comment on attachment 8613283 [details] [review]
[gaia] atiqueahmedziad:019921 > mozilla-b2g:master

Yes, it worked. Thanks 
Please check & review it now :)

Comment 13

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8613283 [details] [review]
[gaia] atiqueahmedziad:019921 > mozilla-b2g:master

LGTM, thanks.

Comment 14

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#9AH_F7btQJSIbhlaLQIxhw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 15

[Gabriele Svelto [:gsvelto]]

Manually merged to gaia/master 8d7c5538c730f637b6eb68e9ab8369251399212c

https://github.com/mozilla-b2g/gaia/commit/8d7c5538c730f637b6eb68e9ab8369251399212c

Try run:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=94bfe7e54baad589c5da8e6c4a0debf12c02f6dc

Comment 16

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8613283 [details] [review]
[gaia] atiqueahmedziad:019921 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1106185
[User impact] if declined: The hangup button visibly changes size when putting a call on hold
[Testing completed]: Tested on a device and on the emulator
[Risk to taking this patch] (and alternatives if risky): The patch is minuscule and very low risk which is why I'm nom'ing it, the alternative is not taking it at all
[String changes made]: None

Comment 17

[Josh Cheng [:josh]]

Comment on attachment 8613283 [details] [review]
[gaia] atiqueahmedziad:019921 > mozilla-b2g:master

Approving as this is low risk. Requesting QA verify after patch landed on 2.2.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/68cb0f91f2884c3cbb2a4dd097dabe46d30904d3

Comment 19

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v2.2&3.0 and Nexus 5 v2.2&3.0 by the STR in Comment 0.

Actual results: End button does not get wider anymore and always shows its normal size.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/20


---------------------------------------------------------------------------
Device: Flame v2.2 build(Pass)
Build ID               20150603162502
Gaia Revision          b92e782ca12397acc3eb52f2e237522c0213f4e0
Gaia Date              2015-06-03 21:02:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/74421c778aff
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.195036
Firmware Date          Wed Jun  3 19:50:46 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v2.2 build(Pass)
Build ID               20150603162502
Gaia Revision          b92e782ca12397acc3eb52f2e237522c0213f4e0
Gaia Date              2015-06-03 21:02:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/74421c778aff
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150603.194836
Firmware Date          Wed Jun  3 19:48:52 EDT 2015
Bootloader             HHZ12f

Device: Flame v3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.192042
Firmware Date          Wed Jun  3 19:20:53 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150603.193140
Firmware Date          Wed Jun  3 19:31:59 EDT 2015
Bootloader             HHZ12f

Comment 20

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4