1127621 - Checkboxes not visible on about:welcomeback

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Matthew N. [:MattN] (PM me if requests are blocking you)]

Attachment: Screen Shot

I can't see any checkboxes and I'm not able to toggle them. I'm guessing this is related to bug 1087618 but perhaps it was broken before.

[Tracking Requested - why for this release]: regression (version unknown)

Comment 1

[Tim Nguyen :ntim]

This looks like a regression of bug 1087618. about:welcomeback used to include the about:sessionrestore stylesheet, which included the styles for the checkmarks.

To fix this, we can simply copy over the checkbox style from about:sessionrestore to about:welcomeback.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Let's get this fixed soon while it's still fresh.  Tim - assigning to you, but feel free to re-assign to another dev if one is available.

Comment 3

[Tim Nguyen :ntim]

I should be able to fix this (along with other regressions) by the end of next week.

Comment 4

[Tim Nguyen :ntim]

Attachment: Patch (r=jaws)

This was r+ed in bug 1128882. Just split up the changes at jaws' request.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/3ad37a67d2d5

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/3ad37a67d2d5

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ad37a67d2d5