1128882 - [e10s] Unable to Restore all tabs after Refreshing Nightly

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Ada [:adalucinet]]

Reproducible on Nightly 38.0a1 (Build ID: 20150202030232) *only* with e10s enabled
Platforms: Windows 7 64-bit, Ubuntu 14.04 32-bit, Mac OS X 10.9.5 and 10.10

Steps to reproduce:
1. Launch Nightly.
2. Go to about:support
3. Refresh Nightly.
4. After refresh is applied, select any of the 2 available options ('Restore all Windows and Tabs' or 'Restore only the ones you want') and click 'Let's go' button.

Expected result: Tabs/Windows are successfully restored.
Actual result: Tabs/Windows are not restored.

Notes:
1. Regressed by bug 1087618
2. Screencast: http://goo.gl/tnvwNa
3. Browser Console output: 'TypeError: document.getElementById(...) is null' message thrown by boutSessionRestore.js:109:2

Comment 1

[Ada [:adalucinet]]

Ups, forgot to add the fact that I'm unable to select which tabs to restore via 'Restore only the ones you want' option, issue visible also in the screencast.

Comment 2

[Tim Nguyen :ntim]

Attachment: Patch

Turns out the errorTryAgain id is also needed for aboutWelcomeBack.

Fixes bug 1127621 as well.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8560006 [details] [diff] [review]
Patch

Review of attachment 8560006 [details] [diff] [review]:
-----------------------------------------------------------------

Please separate these patches out so that the aboutWelcomeBack.css changes are in bug 1128882. r=me for both changes.

::: browser/themes/shared/aboutWelcomeBack.css
@@ +23,5 @@
> +
> +treechildren::-moz-tree-image(icon),
> +treechildren::-moz-tree-image(noicon) {
> +  padding-right: 2px;
> +  margin: 0px 2px;

margin: 0 2px;

Comment 4

[Tim Nguyen :ntim]

Attachment: Patch v2

Split up the checkbox fix in bug 1127621.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/9fe9d717e571

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/9fe9d717e571

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9fe9d717e571

Comment 8

[Manojit Ballav]

Bug is fixed!

Comment 9

[David Lawrence [:dkl]]

Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl

Comment 10

[chocolaty7fnm]

OS : Windows 7 ultimate 64-bit.
I have tried to reproduced the bug on nightly 38.0a1(20150202030232)and I have seen the bug in it.
The fixed is verified on nightly 41.0a1(20150521030204).