Closed Bug 1127633 Opened 9 years ago Closed 9 years ago

Upgrade requests to >= 2.2.1

Categories

(support.mozilla.org :: Code Quality, task)

Product:
support.mozilla.org
Component:
Code Quality
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mythmon, Unassigned)

References

Details

(Whiteboard: u= c= p= s=) 

Right now we have requests==1.1.0, which is over two years old now. chief-james (our deployment tool) relies on requests>=2.2.1. As well, requests is a pretty cool library, and it would be good to stay up to date.

A brief skim of requests changelog [1] reveals that the largest changes happened when 1.0 came out. I think the 2.0 bump won't be a major problem for us. And in fact I've been running requests 2.2 in my local virtualenv for a while, and I don't think it has caused any trouble.

This bug is about upgrading requests to >=2.2.1, making sure everything still works, and tracking down anything that requests uses or that uses requests to make sure they are all happy with the upgrade. Here, >=2.2.1 probably means 2.5.1, which is the latest, unless there are any major issues.
Blocks: 1127636
PR: https://github.com/mozilla/kitsune/pull/2345
Commit: https://github.com/mythmon/kitsune/commit/02e8e795cd1cae652657d33ea2814839a3cedd6e

I just deployed this to prod.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.