1127660 - text bubble still remains in Marketplace

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[Peter Chang[:pchang]]

Description
text bubble still remains in Marketplace

Steps to Reproduce
a. select some text
b. long-press one app

Expected Results
Only see context menu

Actual Results
You can see context menu and text bubble

Other Notes


Reproduction Frequency: 100%

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

George, need your help!

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] cctuan:1127660 > mozilla-b2g:master

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive, 
could you check my patch? It blur the app when contextmenu shows.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/570a14c6e17090d67388e8eb1f674145e160ba1f

Comment 6

[Joshua Mitchell (Inactive)]

transferring affected flags from dupe bug 1124830

Comment 7

[Hermes Cheng (inactive after July 27, 2015)]

Hi George, could you uplift to v2.2? Thanks.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8563218 [details] [review]
PR to master

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):  Not a regression nor a feature.
User impact if declined: as bug described in comment 0, unexpected bubble shows on context menu.
Testing completed: Yes, I have manually tested and wrote unit test.
Risk to taking this patch (and alternatives if risky): No. Unless there's someone don't want to lost focus on current app when launching context menu, but I don't find any case so far.
String or UUID changes made by this patch:

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 8563218 [details] [review]
PR to master

approving given copypaste is new to this release.

Comment 10

[Hermes Cheng (inactive after July 27, 2015)]

(In reply to bhavana bajaj [:bajaj] from comment #9)
> Comment on attachment 8563218 [details] [review]
> PR to master
> 
> approving given copypaste is new to this release.

Ryan, could you please land the patch to v2.2 since it was approved by Bhavana?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Yes, no need to ni? for it.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/5e797e38bf50b543791cd457762bf978b01f65a9

Comment 13

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified on Aries and Flame. Following STR, only context menu shows and not the text selection bubble. Also verified the scenario on the duped bug 1124830 is fixed.

Device: Flame 2.2
BuildID: 20150903032507
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: c03e2bc6a3a4
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Aries 2.5
BuildID: 20150903121826
Gaia: a55d3d512a765bd483bd595b0c8f80c5f1d61b65
Gecko: 74fbd245369c474beaa7f2b1959570243e3dafaa
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.5
BuildID: 20150903030230
Gaia: 29f363d6236bf7db8141d7a1f1185a1dcd809bf7
Gecko: a6786bf8d71d4cf40c3d40e06d8e3c9866863475
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0