1127690 - [flatfish] build break in gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

Attachment: build.log

Below is error message:
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'virtual nsresult GonkGPSGeolocationProvider::Startup()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:874:7: error: 'mObservingSettingsChange' was not declared in this scope
       mObservingSettingsChange = true;
       ^
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'virtual nsresult GonkGPSGeolocationProvider::Shutdown()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:941:7: error: 'mObservingSettingsChange' was not declared in this scope
       mObservingSettingsChange = false;
       ^
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'virtual nsresult GonkGPSGeolocationProvider::Observe(nsISupports*, const char*, const char16_t*)':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1074:41: error: 'kSettingRilDefaultServiceId' was not declared in this scope
     } else if (setting.mKey.EqualsASCII(kSettingRilDefaultServiceId)) {
                                         ^
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1076:57: error: 'IsValidRilServiceId' was not declared in this scope
           !IsValidRilServiceId(setting.mValue.toNumber())) {
                                                         ^
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1080:7: error: 'mRilDataServiceId' was not declared in this scope
       mRilDataServiceId = setting.mValue.toNumber();
       ^
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1081:28: error: 'UpdateRadioInterface' was not declared in this scope
       UpdateRadioInterface();

Comment 1

[Danny Liang [:dliang]]

Hi Sku,
The build break might be caused by your commit, could you help to check it?

commit 32fc68464e9007d8c9248d09d22d7a319501897f
Author: Shawn Ku <[e-mail]>
Date:   Mon Jan 19 10:51:57 2015 +0800

    Bug 878748 - [dolphin] B2G GPS: acquire correct RadioInterface instance in MultiSIM configuration. r=KanRu.

Comment 2

[shawn ku [:sku]]

Attachment: Bug 1127690 - [flatfish] build break in gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp

Comment 4

[shawn ku [:sku]]

Attachment: Bug 1127690 - [flatfish] build break in gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp. r=KanRu.

Comment 5

[shawn ku [:sku]]

try looks good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=55d19bc151a8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/169dc0d84256

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/169dc0d84256