1126497 - [flatfish] build from master fails in GonkGPSGeolocationProvider.cpp

Status: RESOLVED DUPLICATE of bug 1127690

(Firefox OS Graveyard :: General, defect)

Description

[guillaume]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150125222008

Steps to reproduce:

Compile B2G from master using the instructions from https://wiki.mozilla.org/FirefoxOS/TCP/Patching


Actual results:

Build fails with the following errors:

Unified_cpp_dom_system_gonk0.o
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'virtual nsresult GonkGPSGeolocationProvider::Shutdown()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:943:7: error: 'mObservingSettingsChange' was not declared in this scope
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'virtual nsresult GonkGPSGeolocationProvider::Observe(nsISupports*, char const*, char16_t const*)':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1076:41: error: 'kSettingRilDefaultServiceId' was not declared in this scope
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1078:57: error: 'IsValidRilServiceId' was not declared in this scope
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1082:7: error: 'mRilDataServiceId' was not declared in this scope
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:1083:28: error: 'UpdateRadioInterface' was not declared in this scope

In GonkGPSGeolocationProvider.h, some variables such as mObservingSettingsChange are declared conditionally using #ifdef MOZ_B2G_RIL.
It seems that some #ifdef are missing in GonkGPSGeolocationProvider.cpp

This issue is similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1033687

Comment 1

[Juan Gomez [:_AtilA_] (CET/CEST)]

Confirmed

Comment 2

[brad]

Also having the same issues.

Comment 3

[Théo Chevalier]

Looks like it's already being fixed in bug 1127690