1127770 - [Calendar] Short week day names on month view are wrong when weekStartsOnMonday = 1

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Théo Chevalier]

Attachment: Issue - 2.0 vs. 3.0 in French

For locales where weekStartsOnMonday = 1 (French for instance [1]), the short week day names displayed at the top of month view are wrong.

See attached screenshot comparing 2.0 with current master, it's probably easier to understand what I mean.



[1] https://hg.mozilla.org/gaia-l10n/fr/file/c0718864b286/shared/date/date.properties#l206

Comment 1

[Théo Chevalier]

+ qawanted to check 2.1 and 2.2.

Comment 2

[Francesco Lodolo [:flod]]

I can confirm it happens on 2.2

Comment 3

[Miller Medeiros [:millermedeiros]]

BTW, we are deprecating the `weekStartsOnMonday` in favor of `firstDayOfTheWeek` (because in some locales the week starts on Saturday)

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Flame 2.1 screenshot

Flame 2.1 is unaffected. See screenshot.

Device: Flame 2.1
BuildID: 20150130061138
Gaia: 63f291df9b9ad8498fb8fc7fb8bf070524406a5c
Gecko: cd88c8b3cb43
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 6

[Miller Medeiros [:millermedeiros]]

?ni me to check why this happened; not sure if it was introduced during month view refactor, a11y work, RTL, or if it's just something that changed on the french locale.

Comment 7

[Dylan Oliver [:doliver]]

triage: blocking for regression

Comment 8

[Miller Medeiros [:millermedeiros]]

this should be fixed after we update the french locale and add the `firstDayOfTheWeek = 1` to "date.fr.properties".

we already have the proper `weekday-${i}-single-char` for fr (http://transvision.mozfr.org/?recherche=apps%2Fcalendar%2Fcalendar.properties&repo=gaia&sourcelocale=en-US&locale=fr&search_type=entities).

one thing that is weird to me is that transvision still doesn't know about `firstDayOfTheWeek` even for the en-US locale.

this string was added because on some locales the first day of the week is actually Saturday.

Comment 9

[Francesco Lodolo [:flod]]

Gaia Master on Transvision maps to gaia-l10n (there's no Gaia 2.2 until l10n actually branches)
https://hg.mozilla.org/gaia-l10n/

gaia-l10n is not currently mapping master but 2.2, the problem is that 2.2 string extraction was stuck because of bug 1105304. Next week it should start updating again.

Comment 10

[Théo Chevalier]

The weird part is that I can't reproduce anymore on master...

Until now I hadn't changed anything to the French l10n, but I just pushed tonight firstDayOfTheWeek = 1 to master and 2.2 French l10n repo : https://hg.mozilla.org/gaia-l10n/fr/rev/ba490d6af1e4#l4.15

Let's see in next build if it's still working.

Comment 11

[Théo Chevalier]

Actualy Flame OTA has been made available a few minutes ago. With firstDayOfTheWeek = 1 now on French locale, weeks are starting on monday (as expected) and the short name is now right (L for Lundi, D for Dimanche, etc.)

I guess a check on 2.2 wouldn't hurt.

Comment 12

[Dylan Oliver [:doliver]]

ni? to Théo as a reminder to check this one on 2.2 and comment here.

Comment 13

[Théo Chevalier]

Alright, looks good on 2.2 as well.
As said in c#8, this will be fully fixed once the string firstDayOfTheWeek will be translated for each locale.
No branch affected, I guess we can close this one ;)

Checked on Flame with French on the following build

Gaia-Rev        ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d04b78eeb536
Build-ID        20150213002503
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141214.073044
FW-Date         Sun Dec 14 07:30:57 EST 2014
Bootloader      L1TC000118D0