1127791 - [Loop] "You are the only one in the room" message disappear in Device B when User A receives a GSM call and tries to join to the room.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Fire E 2.0
Loop 1.1.1/d4d66d37

Prerequisites:
Device A logged in Mobile Loop application with FxA.
Device B logged in Mobile Loop application with MobileID.
Device A has created and shared a Room with Deivce B via SMS.


STRs:
1. Device B joins to the room -> ER1, AR1
2. Device A makes a GSM call to Device C and Device C picks up the GSM call.
3. Device A taps on "home" button, taps on the room, taps on "Join" button. ER2, AR2


Actual result:
AR1:  "You are the only one in the room" message is showns in Device B. and Device A see a notification about device B is joined.
AR2: An error message is shown in Device A and in Device B  *isn't* shown "You are the only one in the room" message.

Expected result:
ER1:  "You are the only one in the room" message is showns in Device B. and Device A see a notification about device B is joined.
ER2: An error message is shown in Device A and in Device B  is shown "You are the only one in the room" message.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/541

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> Created attachment 8557116 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/541

The patch in the pull request above makes "You are the only one in the room" message in device B when device A is unable to join the room because of the GSM call active.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/87b3ef4c3f00c2027c79b824f651cae40ec6b16d

Comment 4

[Maria Angeles Oteo (:oteo)]

Low risk patch, tested and works fine, "You are the only one in the room" message is shown now in Device B all the time, even when User A tries to join the Room and is notified about the error.

Giving the approval to 1.1.1 branch. Jose Antonio, please, update the fix when you have time, thanks a lot!!

I have seen with Jose Antonio, that in user B device a "leaving" tone is played when user A tries to join the Room and the corresponding error is communicated. This small issue was happening before launching this patch and we will handle it and try to fix it in another bug.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Landed on 1.1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/66e46db04a186ed16ce9325779d19d4b62ddbce0

Comment 6

[Maria Angeles Oteo (:oteo)]

We have opened bug 1128539 to handle the issue explained in comment 4.

Comment 7

[Loli (:lolimartinezcr)]

Tested and now the message "You are the only one in the room" is shown in B.

Fire E 2.0
Loop 1.1.1/39a5284