1128539 - "leaving a Room" tone is played in Device B when user A tries to join a Room and a GSM call is already in progress in that device

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

See 

Reproduced in Loop master Ç(it also happens in 1.1.1 branch)

Prerequisites:
Device A and B logged in Loop Mobile Client.
Device A has created and shared a Room with Deivce B.


STRs:
1. Device B joins to the room 
2. Device A makes a GSM call to Device C and Device C picks up the GSM call.
3. Device A taps on "home" button, taps on the room, taps on "Join" button.


Actual result:
Device B see  "You are the only one in the room" in the Room call screen all the time but a "leaving a Room" tone is played in Device B when user A tries to join that Room

Expected result:
No sound should be played, as User A has not entered in the Room, User B should not hear a "leaving" tone.

Comment 1

[Maria Angeles Oteo (:oteo)]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1127791#c4

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/546

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Landed in master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/c397aa32d3c0692d1bc596f99adeff5cd026e52f

Comment 4

[Maria Angeles Oteo (:oteo)]

Tested and the issue is completely fixed. 
Low risk bug so giving the approval to 1.1.1 branch?

Jose Antonio, could you be so kind of uplifting the patch? and thanks a lot!

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Landed in 1.1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/75aa78f4641e10e82ad1cc02feb92a2c7d39dce3