Closed
Bug 1127853
Opened 11 years ago
Closed 9 years ago
Restructure ReaderMode.js
Categories
(Firefox for iOS :: Reader View, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: st3fan, Assigned: nalcock)
References
Details
Attachments
(1 file)
Use the same anonymous function and window.__firefox__ setup that Client/Assets/Favicons.js does.
Not super high priortity but will be nice to have since it also simplifies the code. (Ie, 'this' will actually work so no more need to prefix everything with _firefox_ReaderMode.)
|
||
Updated•11 years ago
|
Blocks: iosreaderview
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nalcock
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8770994 -
Flags: review?(sarentz)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8770994 -
Flags: review?(sarentz)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8770994 -
Flags: review?(bnicholson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8770994 [details] [review]
Pull request
LGTM
Attachment #8770994 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•