Closed Bug 1127929 Opened 5 years ago Closed 5 years ago
Monkey: Inline SIMD .int32x4 .and calls
Could I work on this bug?
(In reply to Victor Carlquist from comment #1) > Could I work on this bug? Sure, I've assigned you to this bug ;)
Assignee: nobody → victorcarlquist
Status: NEW → ASSIGNED
This patch inline the Int32x4.and call.
Attachment #8558506 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8558506 [details] [diff] [review] Patch Review of attachment 8558506 [details] [diff] [review]: ----------------------------------------------------------------- This looks awesome :) I will send this patch to Try. We might wait a bit for Benjamin to add a few SIMD benchmarks on AWFY . This way we would be able to see how much this patch improve the speed of IonMonkey ;)  http://arewefastyet.com
Attachment #8558506 - Flags: review?(nicolas.b.pierron) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93fd0e8fa422 Feel free to open a bug to implement other SIMD operations as well. Also, you might want to request access to push to Try yourself ;)  https://www.mozilla.org/en-US/about/governance/policies/commit/
(In reply to Nicolas B. Pierron [:nbp] from comment #5) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=93fd0e8fa422 > > Feel free to open a bug to implement other SIMD operations as well. > Also, you might want to request access to push to Try yourself ;) > >  https://www.mozilla.org/en-US/about/governance/policies/commit/ It's really Awesome! Thank you very much ;) The Try is red because I need to rebase the patch. I'll do it now.
(In reply to Victor Carlquist from comment #7) > Created attachment 8558665 [details] [diff] [review] > Patch rebased. And pushed to Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db165ba6d710
Hopefully, this one should stay, and not be back out because of some weird error on Windows 8 ;) https://hg.mozilla.org/integration/mozilla-inbound/rev/ed0a31f8bdc6
For your information, we should expect a speed-up on the benchmarks that Benjamin added to AreWeFastYet . Have a look at asmjs-ubench-fbirds-native and asmjs-ubench-mandelbrot-native.  http://arewefastyet.com/#machine=28&view=breakdown&suite=asmjs-ubench
Nice! I agree ;) Ok, I'll have a look at the benchmarks. Thanks.
You need to log in before you can comment on or make changes to this bug.