1128083 - [marker] Cycle collection should be shown in the timeline

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Memory management in Firefox comes in two forms: garbage collection (GC), and cycle collection (CC).

To make things more fun, CC will often trigger a GC!

Right now the timeline only shows GC, but it should also show CC -- we are missing half of the picture.

Comment 1

[Victor Porof [:vporof][:vp]]

Moving into the Profiler component. Filter on GUTHRIE'S WAVY CAKES.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Related bug for GC, bug 1136945, and via panos' memory tool https://github.com/past/memory-profiler/blob/master/chrome/tool.js#L201

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Is any platform work needed for this? Or does exposing GC info via bug 1137527 solve the platform work as well?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Main thread CC statistics are exposed using "cycle-collection-statistics" observer service notification.

http://mxr.mozilla.org/mozilla-central/source/dom/base/nsJSEnvironment.cpp?rev=0b0c492a33b5#1726

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Olli Pettay [:smaug] from comment #4)
> Main thread CC statistics are exposed using "cycle-collection-statistics"
> observer service notification.
> 
> http://mxr.mozilla.org/mozilla-central/source/dom/base/nsJSEnvironment.
> cpp?rev=0b0c492a33b5#1726

We aren't using that observer directly because its a huge pain to synchronize prefs being used across multiple debugger servers and multiple actors within those debugger servers, and we can't control it on a per debuggee global basis.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Fixed in bug 1141614.