1128177 - Dialog to clear data when exiting Firefox needs more space between two columns (in-content preferences)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Francesco Lodolo [:flod]]

Attachment: clear.png

This screenshot is taken on a localized build (Italian), there's no gutter between the columns. Not sure if it's evident in English as well, given that's usually shorter.

Comment 1

[Richard Marti (:Paenglab)]

The width of the first column depends on column.width2 in mozilla/browser/locales/en-US/chrome/browser/sanitize.dtd. This could be increased but needs a check if it also works in normal prefs.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Screenshot 20/40

Then we have another issue: this is a screenshot of the window with dialog 40em, column 20em (the text is slightly different because I wanted to make sure I wasn't hitting cached elements).

It's completely asymmetrical. To have something better I need to use 25em for the column, which also means I can't have the same value for old/in-content prefs.

http://hg.mozilla.org/mozilla-central/file/default/browser/locales/en-US/chrome/browser/sanitize.dtd#l57

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

What do you think about this? I didn't tweak the values for en-US yet, but if you're good with this approach then I can find what works before checking this in.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8559583 [details] [diff] [review]
Patch

Review of attachment 8559583 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh. I hate XUL layout sometimes.

But yes, this would work.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Landed with an adjusted column width for the in-content preferences, and tweaked the related localization note.

https://hg.mozilla.org/integration/fx-team/rev/f15ed7846547

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f15ed7846547

Comment 7

[Stefan Plewako [:stef]]

What version are incontent preferences targeted at?

I'm asking because after this, with incontent preferences disabled width of the clear recent history dialog and clear data when exiting Firefox settings dialog share the value of dialog.width2 entity but do not share styling…

Comment 8

[:Gijs (he/him)]

(In reply to Stefan Plewako [:stef] from comment #7)
> What version are incontent preferences targeted at?

38.

> I'm asking because after this, with incontent preferences disabled width of
> the clear recent history dialog and clear data when exiting Firefox settings
> dialog share the value of dialog.width2 entity but do not share styling…

Please file a separate bug. Also (and please answer this in that new, separate bug) - wasn't this the case before this fix? Doesn't seem like a regression to me...

Comment 9

[Stefan Plewako [:stef]]

Right, the issue predates this and there is already bug for it…
https://bugzilla.mozilla.org/show_bug.cgi?id=494210