1128332 - mediasource-duration.html test doesn't fire loadeddata

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

This started after upgrading to m-c last Friday (last version where everything worked was 29b05d283b00) using patch queue from 1125776

loadeddata event is never fired in the webref test mediasource-duration.html 'Test abort in the middle of an initialization segment.' causing it to timeout.

This only seems to appear on Windows 8 and 7 on try.

Comment 1

[Jean-Yves Avenard [:jya]]

same issue with mediasource-append-buffer.html

which does the same thing as mediasource-duration.html: waiting for loaded data after adding the same segments as above.

I had it happening once on Windows XP (over 20+ runs)

Comment 2

[Jean-Yves Avenard [:jya]]

Interestingly, I now get it consistently for mediasource-append-buffer.html Test abort in the middle of an initialization segment.

and it succeeds on mediasource-duration.html on W7..

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: reader-1211f1b00.zip

Test to reproduce the problem.

The what's happening is that we have a partial mediasegment (complete moof but partial mdat).

MDSM calls RequestAudioData with mLastAudioTime=0 ; this fails as no audio data is available yet.

MediaSourceReader::OnAudioNotDecoded is called back with END_OF_STREAM.
mLastAudioTime is then adjusted to the end of the current stream to see if another one is available and that we could switch to.

And the audio mediapromise is rejected with WAITING_FOR_DATA

The 3rd appendBuffer does add the audio, however is audio add is between 0 and 0.5s.
As mLastAudioData was adjusted to be 0.53s we will never get audio data.

So loadeddata is never fired, and the test timeout.

This is a racey behaviour as if appendData happened to run before RequestAudioData is called, the test will succeed.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Part1. Add useful informations to logging

Transferring from bug 1141785

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8577994 [details] [diff] [review]
Part1. Add useful informations to logging

carrying r+ by :mattwoodrow

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Don't consider decoding error as fatal

Transferring from bug 1141785

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8577995 [details] [diff] [review]
Part2. Don't consider decoding error as fatal

Carrying r+ from :mattwoodrow

Comment 8

[Jean-Yves Avenard [:jya]]

Attachment: Part3. Re-attempt to decode from last failed position

Retry from last failing position.

Comment 9

[Jean-Yves Avenard [:jya]]

Attachment: Part4. Update webref results

update webref accordingly

Comment 10

[Jean-Yves Avenard [:jya]]

Comment on attachment 8578012 [details] [diff] [review]
Part3. Re-attempt to decode from last failed position

This causes failure of test_WaitingOnMissingData_mp4.html

I don't think we actually fail as such, but we don't pass the test on where playback stall.

Comment 11

[Jean-Yves Avenard [:jya]]

Attachment: Part3. Re-attempt to decode from last failed position

Only use previous location if we were well within the current buffered range

Comment 12

[Jean-Yves Avenard [:jya]]

Test still occasionally timing out, will open a new bug 1143999 as the cause for this one was identified

Comment 13

[Jean-Yves Avenard [:jya]]

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c5aba53c37c
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/782ccaeb2516
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/75e796723b11
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/053badf57403

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7c5aba53c37c
https://hg.mozilla.org/mozilla-central/rev/782ccaeb2516
https://hg.mozilla.org/mozilla-central/rev/75e796723b11
https://hg.mozilla.org/mozilla-central/rev/053badf57403

Comment 15

[Jean-Yves Avenard [:jya]]

Comment on attachment 8577994 [details] [diff] [review]
Part1. Add useful informations to logging

Approval request for all patches.

Approval Request Comment
[Feature/regressing bug #]:1128332
[User impact if declined]:Less spec compliant. webref test failing
[Describe test coverage new/current, TreeHerder]:in m-c for over a week.
[Risks and why]: Low, it prevents a race condition that would cause intermittent failure
[String/UUID change made/needed]: None

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/804fbc039725
https://hg.mozilla.org/releases/mozilla-aurora/rev/a3ddca520a58
https://hg.mozilla.org/releases/mozilla-aurora/rev/030201a8f8ed
https://hg.mozilla.org/releases/mozilla-aurora/rev/8333cdfb08e8

Comment 17

[Jean-Yves Avenard [:jya]]

I had W3 failure on my aurora try run, that's why I didn't push it. Obviously missing a dependency :(