Closed Bug 1128489 Opened 7 years ago Closed 7 years ago
Use direct call between Settings
Service and Settings Request Manager
+++ This bug was initially created as a clone of Bug #1124622 +++ One of the reason of the latency at boot time documented in bug 1124622 comes from the way communication is done between SettingsService and SettingsRequestManager: via async messaging. This makes messages taking quite some time to be delivered. Figures shows that we can win 3-4 secs on boot time (from gecko startup to calling shell.start()) by changing the communication and make it direct between both objects rather than making use of SendAsyncMessage/ReceiveMessage. Kyle, I know this is breaking your heart and that you wanted to have a consistent way of communicating for SettingsManager and SettingsService, so do you agree on the idea of changing this communication ? We should be allowed to do this because those two components do live in the same process.
Summary: Use direct call betweek SettingsService and SettingsRequestManager → Use direct call between SettingsService and SettingsRequestManager
Oh, yeah, go for it. Consistency was nice but speed is important, and gwagner and I have discussed doing far worse things now too. :)
Attachment #8557957 - Flags: review+
Updated the patch: I've noticed that unregisterLock() was done before we received the Settings:Finalize:OK message, so I've moved it a little bit. Matching try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dacfd3573f11
Attachment #8557957 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.