Closed Bug 1128549 Opened 10 years ago Closed 5 years ago

JavaScript warnings from |make mozmill| code (FULL DEBUG C-C TB. These are not from thunderbird code itself)

Categories

(Thunderbird :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ishikawa, Unassigned)

Details

This is the list of JavaScript strict warning lines that are printed during |make mozmill| test of FULL DEBUG build of TB. It was captured last week, but it showed the status of problems with mozmill code under new stricter checking of JS engine since last Summer. ======================================== JavaScript strict warning jquery.js and jquery-ui.js are ignored. (MOZMILL part) ======================================== 35 JavaScript strict warning: resource://mozmill/stdlib/securable-module.js, line 355: ReferenceError: assignment to undeclared variable name 35 JavaScript strict warning: resource://mozmill/stdlib/os.js, line 82: ReferenceError: assignment to undeclared variable mPlatform 35 JavaScript strict warning: resource://mozmill/stdlib/os.js, line 65: ReferenceError: assignment to undeclared variable p 35 JavaScript strict warning: resource://mozmill/stdlib/httpd.js, line 2795: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function 35 JavaScript strict warning: resource://mozmill/stdlib/arrays.js, line 41: ReferenceError: assignment to undeclared variable i 35 JavaScript strict warning: resource://mozmill/modules/utils.js, line 131: TypeError: variable appention redeclares argument 35 JavaScript strict warning: resource://mozmill/modules/mozmill.js, line 92: ReferenceError: assignment to undeclared variable applicationDictionary 35 JavaScript strict warning: resource://mozmill/modules/mozmill.js, line 190: ReferenceError: assignment to undeclared variable MozMillAsyncTest 35 JavaScript strict warning: resource://mozmill/modules/frame.js, line 76: ReferenceError: assignment to undeclared variable mozmill 35 JavaScript strict warning: resource://mozmill/modules/frame.js, line 76: ReferenceError: assignment to undeclared variable modules 35 JavaScript strict warning: resource://mozmill/modules/frame.js, line 76: ReferenceError: assignment to undeclared variable elementslib 35 JavaScript strict warning: resource://mozmill/modules/frame.js, line 70: ReferenceError: assignment to undeclared variable arrayRemove 35 JavaScript strict warning: resource://mozmill/modules/frame.js, line 564: ReferenceError: assignment to undeclared variable thread 35 JavaScript strict warning: resource://mozmill/modules/frame.js, line 436: ReferenceError: reference to undefined property test_module[i]._mozmillasynctest 35 JavaScript strict warning: resource://mozmill/modules/frame.js, line 177: ReferenceError: assignment to undeclared variable timers 35 JavaScript strict warning: resource://mozmill/modules/elementslib.js, line 444: TypeError: variable exp redeclares argument 35 JavaScript strict warning: resource://mozmill/modules/elementslib.js, line 261: SyntaxError: test for equality (==) mistyped as assignment (=)? 35 JavaScript strict warning: resource://mozmill/modules/controller.js, line 1341: ReferenceError: assignment to undeclared variable MozMillAsyncTest 35 JavaScript strict warning: resource://mozmill/modules/controller.js, line 1336: ReferenceError: assignment to undeclared variable controllerAdditions 35 JavaScript strict warning: resource://mozmill/modules/controller.js, line 100: ReferenceError: assignment to undeclared variable waitForEvents 33 JavaScript strict warning: resource://mozmill/modules/utils.js, line 92: ReferenceError: assignment to undeclared variable w 6 JavaScript strict warning: resource://mozmill/modules/controller.js, line 312: ReferenceError: reference to undefined property node.tagName I think these are rather straight-forward to fix, but I am not sure how to fix them properly since every invocation of "mach" (or make -f client.mk) seems to try to install an original version to a directory inside OBJECT directory. (Or maybe I misunderstand the files are copied. But I could not let my changes persist in mozmill code last time I tried.) TIA PS: These warning lines really detract our attention when we are looking at the log file when a bug is suspected. (Yes, I am one of the few people in the world who read DEBUG BUILD tty console log from time to time, and insert my own dump statements in many places to begin with. Without -gsplit-dwarf, running GDB was too much with FULL DEBUG version of TB. Now with -gsplit-dwarf and GNU gold linker, gdb starts up much faster and nicely.)
Maybe these would be fixed by upgrading mozmill? We have bugs filed for that.
(In reply to :aceman from comment #1) > Maybe these would be fixed by upgrading mozmill? We have bugs filed for that. That may be possible. But I wonder when the mozmill upgrade happens, then. TIA

mozmill is gone

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.