Closed Bug 1128761 Opened 5 years ago Closed 5 years ago

Remove apz.subframe.enabled

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file, 1 obsolete file)

One less pref to have working APZ.
Attached patch patch (obsolete) — Splinter Review
Attachment #8558220 - Flags: review?(bugmail.mozilla)
Comment on attachment 8558220 [details] [diff] [review]
patch

Review of attachment 8558220 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsLayoutUtils.cpp
@@ -7655,5 @@
>  nsLayoutUtils::WantSubAPZC()
>  {
> -  // TODO Turn this on for inprocess OMTC on all platforms
> -  bool wantSubAPZC = gfxPrefs::AsyncPanZoomEnabled() &&
> -                     gfxPrefs::APZSubframeEnabled();

This function looks different as of bug 950934; your patch needs rebasing. After rebasing you can even get rid of this function and just inline the remaining APZC check into the call sites.
Attachment #8558220 - Flags: review?(bugmail.mozilla)
Attached patch rebasedSplinter Review
Attachment #8558220 - Attachment is obsolete: true
Attachment #8558753 - Flags: review?(bugmail.mozilla)
Comment on attachment 8558753 [details] [diff] [review]
rebased

Review of attachment 8558753 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with tests deduplicated.

::: layout/reftests/async-scrolling/reftest.list
@@ +19,3 @@
>  
>  pref(layout.async-containerless-scrolling.enabled,false) skip-if(!asyncPanZoom) == bg-fixed-1.html bg-fixed-1-ref.html
>  pref(layout.async-containerless-scrolling.enabled,false) skip-if(!asyncPanZoom) == bg-fixed-cover-1.html bg-fixed-cover-1-ref.html

Some of the tests down here are now redundant. Deduplicate please.
Attachment #8558753 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/d3b41b0ead7d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1192219
Depends on: 1122916
You need to log in before you can comment on or make changes to this bug.