1128761 - Remove apz.subframe.enabled

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

One less pref to have working APZ.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8558220 [details] [diff] [review]
patch

Review of attachment 8558220 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsLayoutUtils.cpp
@@ -7655,5 @@
>  nsLayoutUtils::WantSubAPZC()
>  {
> -  // TODO Turn this on for inprocess OMTC on all platforms
> -  bool wantSubAPZC = gfxPrefs::AsyncPanZoomEnabled() &&
> -                     gfxPrefs::APZSubframeEnabled();

This function looks different as of bug 950934; your patch needs rebasing. After rebasing you can even get rid of this function and just inline the remaining APZC check into the call sites.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: rebased

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8558753 [details] [diff] [review]
rebased

Review of attachment 8558753 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with tests deduplicated.

::: layout/reftests/async-scrolling/reftest.list
@@ +19,3 @@
>  
>  pref(layout.async-containerless-scrolling.enabled,false) skip-if(!asyncPanZoom) == bg-fixed-1.html bg-fixed-1-ref.html
>  pref(layout.async-containerless-scrolling.enabled,false) skip-if(!asyncPanZoom) == bg-fixed-cover-1.html bg-fixed-cover-1-ref.html

Some of the tests down here are now redundant. Deduplicate please.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d3b41b0ead7d

w/ nits fixed

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d3b41b0ead7d