Thank you for helping out with Treeherder! You can find us on IRC at irc://irc.mozilla.org/treeherder Here's some links to help get you started. Project page: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder Interacting with us, repo locations and links to set up a development version of the software: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs A-Team general reference, coding style guides: http://ateam-bootcamp.readthedocs.org
It only allows to load the next page, but not the previous one.
Whiteboard: [good first bug]
Hey, Can I take this up? I set it up locally. Could you give me instructions to reproduce this? I couldn't find 'similar jobs' page.
The "similar jobs" tab is part of the bottom panel. This will show up when you click on a job button (one of those symbols in the main content area). When you open that tab, the list of similar jobs is paginated, but there's no way to select the previous page when you are at page 2+. The files to modify are in this folder: https://github.com/mozilla/treeherder-ui/tree/master/webapp/app/plugins/similar_jobs Feel free to ping me on irc (#treeherder) if you have any doubt
Created attachment 8566573 [details] showPreviousJobs_current Just adding a screen grab of what we have presently. I am guessing we want perhaps something like a "< prev" and "next >" or "< older" and "newer >" in the footer, when applicable.
I "removed" pagination in bug 1095100 and instead just append the next 20 jobs to the list, so if we want a concise user-experience to the main view we probably should go that route.
(In reply to Johannes Pfrang [:johnp] from comment #4) > I "removed" pagination in bug 1095100 and instead just append the next 20 > jobs to the list, so if we want a concise user-experience to the main view > we probably should go that route. I agree. We could probably have a next|20|50| on one side and prev|20|50| on the other side of the Similar Jobs panel footer. Maybe even the same visual style as our main resultset footer nav (square boxes), but perhaps minus the grey footer bar, and smaller.
Whiteboard: [good first bug] → [good first bug][lang=js]
Hey Jonathan, I would Like to work on it so can you assign it to me
14.geevan, are you still interested in working on this per comment 1? Otherwise we'd like to probably reassign. Thanks!
(In reply to Jonathan French (:jfrench) from comment #7) > 14.geevan, are you still interested in working on this per comment 1? > Otherwise we'd like to probably reassign. Thanks! Sorry, I had forgotten about this. You may reassign it to Gaurav. No problem.
No problems 14.geevan, feel free to drop by for another bug any time. I sent Gaurav another possible bug to look at also, so I will wait to see which one he prefers.
Gaurav prefers this one, so assigning :)
Assignee: nobody → deathping1994
Status: NEW → ASSIGNED
Just a head's up, we've unified our treeherder and treeherder-ui repos, so any change would need to occur in https://github.com/mozilla/treeherder, and a PR opened there.
Hi Gaurav, just checking are you still interested in fixing this? I can reassign the bug if needed.
(In reply to Jonathan French (:jfrench) from comment #12) > Hi Gaurav, just checking are you still interested in fixing this? I can > reassign the bug if needed. I could take this back if it's okay with Gaurav.
(In reply to Jeevan M R (:jee1mr) from comment #13) > (In reply to Jonathan French (:jfrench) from comment #12) > > I could take this back if it's okay with Gaurav. Hi Jeevan, we had another contributor in channel (moijes12) expressing interest in possibly this bug. Mostly that was my reason for asking, but if there's others you'd like to fix feel free to check out bugsahoy and our wiki bug tables. Thanks!
(In reply to Jonathan French (:jfrench) from comment #12) > Hi Gaurav, just checking are you still interested in fixing this? I can > reassign the bug if needed. I completely forgot about it,Sorry for the late reply. Yes you can assign it to anybody who is interested. I solved it partially so if the someone needs help or wants to continue where I left,I am available between 7pm to 2 am (Indian time)
Thanks Gaurav, setting to unassigned.
Assignee: deathping1994 → nobody
Status: ASSIGNED → NEW
It appears we now do additive loading of Similar Jobs. "Show previous jobs" loads more, and the existing ones don't fall off the panel. So the idea of 'next'(aka. previous) may no longer be required since everything is always present. Mauro can you confirm I'm not missing something? :)
Yeah that's correct.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.