1128981 - [RTL] "No SIM inserted" message etc is misplaced for RTL languages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jonathan Kew [:jfkthame]]

STR: With no SIM installed, change language to Arabic, then pull down the Notification panel.

The Arabic version of the message

  No SIM inserted
  Insert a SIM to enable Usage

should be flush-right, but appears on the left-hand side of the screen, somewhat truncated at the edge.

I would post a screenshot, but am having trouble getting my current build to produce one. :(

Comment 1

[Jonathan Kew [:jfkthame]]

Also, the second line of this text (the Arabic rendering of "Insert a SIM to enable Usage") is clipped at the bottom, making some of the characters illegible. This happens because of the use of an overly-constrained line height in the CSS for the p.meta element.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: [PR] fix the Cost Control widget rendering for RTL languages

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks for the patch Jonathan! Please request review from a system peer like :alive or :kgrandon.

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8558590 [details] [review]
[PR] fix the Cost Control widget rendering for RTL languages

Oops, I thought I'd flagged this for review already, but apparently not. Sorry for the delay.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8558590 [details] [review]
[PR] fix the Cost Control widget rendering for RTL languages

This seems to do the job for me, thanks!

Comment 7

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/be64e0a1412c1b8c40b7597c77ed16841bdb152f

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8558590 [details] [review]
[PR] fix the Cost Control widget rendering for RTL languages

Requesting uplift for this RTL feature.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Implementation.
[User impact] if declined: Poor RTL experience when viewing the usage widget.
[Testing completed]: Manual.
[Risk to taking this patch] (and alternatives if risky): Simple styling change, so low risk.
[String changes made]: None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/a17bcb9738beeb73ce1068c0b0817b51f1c84748

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly 3.0 build but is not yet on the latest night 2.2 Build.  Will verify that one on another day.

Results: The "No Sim inserted" message is correctly on the right side and does not get truncated.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150206010204
Gaia: 94af4b42d2ace6c9f38f31de77240604fac68af1
Gecko: 7c5f187b65bf
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Environmental Variables:
Device: Flame 2.2
BuildID: 20150206002505
Gaia: a52999ce7f783177deb17e267bf003a53e6fde06
Gecko: 01446d5231ef
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 11

[KTucker [:KTucker][Inactive 3/4/2016]]

Jayme, assigning this to you so you can verify 2.2 on Monday.

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on Fame 2.2.

Results:  The "No SIM inserted message is correctly on the right and is not cut off.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150209002504
Gaia: e827781324cbde91d2434b388f5dead3303a85ee
Gecko: 0552759956d3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 13

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15475/