1129101 - Custom integer field breaks "Change many bugs at once" functionality

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Daniel Veditz [:dveditz]]

+++ This bug was initially created as a clone of Bug #1123769 +++

bug 1123769 added a new "rank" field. When I try to use the "Change several bugs at once" functionality for buglists the rank field defaults to --do_not_change-- (like most fields). But when I submit my changes (to other fields, leaving rank alone) then I get an error box/overlay saying rank is no in the required format.

Can't figure out a way to work around it (especially since I don't think I have permission to be changing the rank field anyway).

Comment 1

[Daniel Veditz [:dveditz]]

This is apparently due to the pattern="\d+" attribute on the field which is enforced by the browser and does not know about the magic --do_not_change-- value. If I use DevTools to remove the attribute the form works fine on the server side.

Comment 2

[David Lawrence [:dkl]]

Attachment: 1129101_1.patch

Comment 3

[:glob ✱]

that's upstream code, moving.

Comment 4

[:glob ✱]

(In reply to Daniel Veditz [:dveditz] from comment #0)
> Can't figure out a way to work around it (especially since I don't think I
> have permission to be changing the rank field anyway).

fwiw you do have permission to set that field.

Comment 5

[:glob ✱]

Comment on attachment 8558705 [details] [diff] [review]
1129101_1.patch

Review of attachment 8558705 [details] [diff] [review]:
-----------------------------------------------------------------

this looks good for bmo, we'll need a patch for trunk since i moved the goalposts.

Comment 6

[David Lawrence [:dkl]]

Upstream already has this fixed so moving back to BMO to backport the fix instead.

Comment 7

[David Lawrence [:dkl]]

Attachment: 1129101_2.patch

Comment 8

[:glob ✱]

Comment on attachment 8559198 [details] [diff] [review]
1129101_2.patch

Review of attachment 8559198 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 9

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   bb4b3f6..7732e14  master -> master

Comment 10

[Daniel Veditz [:dveditz]]

Thanks for the fix.

(In reply to Byron Jones ‹:glob› from comment #4)
> (In reply to Daniel Veditz [:dveditz] from comment #0)
> > Can't figure out a way to work around it (especially since I don't think I
> > have permission to be changing the rank field anyway).
> 
> fwiw you do have permission to set that field.

True, but randomly re-setting bug rank just to make the form work probably won't win me any friends :-)