1129187 - JavaScript error: Graphs.jsm, line 754: InvalidStateError after bug 1122639 when devtools.performance.ui.enable-memory is false

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Apparently doing canvas stuff inside a hidden node is sad. This patch makes everything load lazily when the containers become visible.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Removed some accidental changes.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8560145 [details] [diff] [review]
v1

Review of attachment 8560145 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/test/browser_perf-overview-render-01.js
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";

These are defined in head.js once bug 1128859 lands

::: browser/devtools/performance/test/browser_perf-overview-selection-02.js
@@ +2,5 @@
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";
> +

ditto

::: browser/devtools/performance/test/browser_perf-overview-selection-03.js
@@ +2,5 @@
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";
> +

blap

::: browser/devtools/performance/test/browser_perf-recording-selected-04.js
@@ +3,5 @@
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";
> +

!

::: browser/devtools/performance/test/browser_perf-states.js
@@ +1,5 @@
> +/* Any copyright is dedicated to the Public Domain.
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";

!

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #3)
> These are defined in head.js once bug 1128859 lands

Ok, making bug 1128859 block this one. Land away!

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v2

Rebased and fixed some tests.

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/1de14614f44e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1de14614f44e