Closed Bug 1129187 Opened 6 years ago Closed 6 years ago

JavaScript error: Graphs.jsm, line 754: InvalidStateError after bug 1122639 when devtools.performance.ui.enable-memory is false

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Summary: JavaScript error: Graphs.jsm, line 754: InvalidStateError after bug 1122639 → JavaScript error: Graphs.jsm, line 754: InvalidStateError after bug 1122639 when devtools.performance.ui.enable-memory is false
Attached patch v1 (obsolete) — Splinter Review
Apparently doing canvas stuff inside a hidden node is sad. This patch makes everything load lazily when the containers become visible.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8560144 - Flags: review?(jsantell)
Attached patch v1 (obsolete) — Splinter Review
Removed some accidental changes.
Attachment #8560144 - Attachment is obsolete: true
Attachment #8560144 - Flags: review?(jsantell)
Attachment #8560145 - Flags: review?(jsantell)
Comment on attachment 8560145 [details] [diff] [review]
v1

Review of attachment 8560145 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/test/browser_perf-overview-render-01.js
@@ +1,5 @@
>  /* Any copyright is dedicated to the Public Domain.
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";

These are defined in head.js once bug 1128859 lands

::: browser/devtools/performance/test/browser_perf-overview-selection-02.js
@@ +2,5 @@
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";
> +

ditto

::: browser/devtools/performance/test/browser_perf-overview-selection-03.js
@@ +2,5 @@
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";
> +

blap

::: browser/devtools/performance/test/browser_perf-recording-selected-04.js
@@ +3,5 @@
>     http://creativecommons.org/publicdomain/zero/1.0/ */
>  
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";
> +

!

::: browser/devtools/performance/test/browser_perf-states.js
@@ +1,5 @@
> +/* Any copyright is dedicated to the Public Domain.
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +const FRAMERATE_PREF = "devtools.performance.ui.enable-framerate";
> +const MEMORY_PREF = "devtools.performance.ui.enable-memory";

!
Attachment #8560145 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #3)
> These are defined in head.js once bug 1128859 lands

Ok, making bug 1128859 block this one. Land away!
Depends on: 1128859
Attached patch v2Splinter Review
Rebased and fixed some tests.
Attachment #8560145 - Attachment is obsolete: true
Attachment #8560586 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/1de14614f44e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.