1129433 - Show "# tabs opened in background" notification in system tray

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

This allows for a persistent method for users to say "Ok, I'm done now, let me switch to Firefox".

We also discussed the possibility of extending this notifications functionality to allow the user to open these tabs on another device. But, more on that later as there are probably nuances we've yet to consider.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Show tabs opened in background notification in system tray

This patch basically just adds a notification with a message of "x tabs queued".  I introduce a plurals file to help with some of the text, also I create a custom intent action which will be consumed in BrowserApp in another bug. 

There's no way to programatically cancel the noticification currently - this will happen once we build the consumer of the new intent action.

Comment 2

[Martyn Haigh (:mhaigh)]

Attachment: Show tabs opened in background notification in system tray

I missed out the new file o_O

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8566597 [details] [diff] [review]
Show tabs opened in background notification in system tray

Review of attachment 8566597 [details] [diff] [review]:
-----------------------------------------------------------------

r+ w/ nits.

::: mobile/android/base/resources/values/plurals.xml
@@ +3,5 @@
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +
> +<resources>
> +    <plurals name="tab_queue_notification_message">

We can't use plurals, follow [1] as an example.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/android_strings.dtd?rev=6706694c76db#441

::: mobile/android/base/tabqueue/TabQueueHelper.java
@@ +26,5 @@
>      public static final String FILE_NAME = "tab_queue_url_list.json";
>      public static final long TOAST_TIMEOUT = 3000;
> +    public static final String LOAD_URLS_ACTION = "TAB_QUEUE_LOAD_URLS_ACTION";
> +
> +    public static final int TAB_QUEUE_NOTIFICATION_ID = 783;

Where does this come from? How do we know it's unique? Perhaps we should off-load this to some library method that ensures notification ids are unique across the product.

@@ +76,5 @@
> +        NotificationCompat.Builder builder =
> +                new NotificationCompat.Builder(context)
> +                        .setSmallIcon(R.drawable.ic_status_logo)
> +                        .setContentTitle(context.getResources().getQuantityString(R.plurals.tab_queue_notification_title, tabsQueued))
> +                        .setContentText(context.getResources().getQuantityString(R.plurals.tab_queue_notification_message, tabsQueued, tabsQueued));

nit: resources as local var

::: mobile/android/base/tabqueue/TabQueueService.java
@@ +153,5 @@
>          (new Thread() {
>              @Override
>              public void run() {
> +                int tabsQueued = TabQueueHelper.queueUrl(GeckoProfile.get(getApplicationContext()), intentData);
> +                TabQueueHelper.showNotification(getApplicationContext(), tabsQueued);

nit: Store application context in local var

Comment 4

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=acf6a9d35488

Comment 5

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/4e033cac2931

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e033cac2931