1145581 - Show tabs when opening fennec from the Tab Queue notification

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

When the user clicks the tab queue notification to open fennec, if there is more than one tab in the tab queue, start fennec with the tabs panel open to give the user a visual confirmation/reminder of the tabs they loaded.  If there's only one url queued, then just load as normal with that tab selected.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Show tabs when opening fennec from the Tab Queue notification

Adds to the onNewIntent method in BrowserApp to detect if the action associated with the new intent is the one we defined in the pending intent when we add a notification (bug 1129433), if so then we open the tabs.  If there's more than one tab opened then also show the tabs panel to aide the user in seeing what tabs they have just loaded.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Comment on attachment 8581887 [details] [diff] [review]
Show tabs when opening fennec from the Tab Queue notification

Review of attachment 8581887 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/BrowserApp.java
@@ +3389,4 @@
>  
>          final boolean isViewAction = Intent.ACTION_VIEW.equals(action);
>          final boolean isBookmarkAction = GeckoApp.ACTION_HOMESCREEN_SHORTCUT.equals(action);
> +        final boolean openTabQueueUrls = TabQueueHelper.LOAD_URLS_ACTION.equals(action);

nit: -> shouldOpenTabQueueUrls or isTabQueueAction

@@ +3416,5 @@
>          }
>  
> +        // If the user has clicked the tab queue notification then load the tabs.
> +        if(AppConstants.NIGHTLY_BUILD  && AppConstants.MOZ_ANDROID_TAB_QUEUE && mInitialized && openTabQueueUrls) {
> +            int queuedTabs = TabQueueHelper.getTabQueueLength(this);

nit: -> queuedTabCount

Comment 3

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e682413d8780

Comment 4

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/d629b3d07fa9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d629b3d07fa9

Comment 6

[Teodora Vermesan (:TeoVermesan)]

If there are 2 links queued, tapping the notification bar will display the tab tray.
If there is only one link queued, tapping the notification bar will load that link in a new tab.

Verified fixed using:
Device: Samsung S5 (Android 4.4)
Build: Firefox for Android 40.0a1 (2015-04-29)