1129539 - stopwatch icon in landing/recording panes in perf++ tool has padding issue in OSX

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-02-04 at 10.46.45 AM.png

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

From bug 1120699, wanted to land that and not be held up by this css issue.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8559843 [details] [diff] [review]
v1

Review of attachment 8559843 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/performance-view.js
@@ +29,5 @@
>    /**
>     * Sets up the view with event binding and main subviews.
>     */
>    initialize: function () {
> +    this._recordButton = $("#main-record-button");

i see your ninja fix

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/dab32e003884

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dab32e003884