Closed Bug 1129631 Opened 5 years ago Closed 5 years ago

Theme for tabs tray

Categories

(Firefox for iOS :: Theme & Visual Design, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
The visual design for the tabs tray is coming together. Lets start implementing:

https://mozilla.invisionapp.com/share/HA254M642#/screens/61500963?maintainScrollPosition=false

note all those aren't consistent, but the major pieces are there. we can start with them.
Attached file Pull request
Lets start reviewing this. Darrin said he's happy to iterate on it in product for a bit, so this is just a start. It adds thumbnails to the tray (using a custom cell view and screenshots grabbed dynamically as we need them), and an animated transition.
Attachment #8559366 - Flags: review?(bnicholson)
Comment on attachment 8559366 [details] [review]
Pull request

I put lots of cleanup/refactoring comments in the PR, so I'd prefer to see a follow-up commit (or responses to the comments) before giving r+.
Attachment #8559366 - Flags: review?(bnicholson) → feedback+
Assignee: nobody → wjohnston
Comment on attachment 8559366 [details] [review]
Pull request

Updated the PR. I made the options argument super specific. Makes me a little sick inside, but I want to get this landed so that we can iterate with UX.

Also fixed the delay using a dispatch to the main thread.
Attachment #8559366 - Flags: feedback+ → review?(bnicholson)
Attachment #8559366 - Flags: review?(bnicholson) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1127043
Depends on: 1135768
You need to log in before you can comment on or make changes to this bug.