1129631 - Theme for tabs tray

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect)

Description

[Wesley Johnston (:wesj)]

The visual design for the tabs tray is coming together. Lets start implementing:

https://mozilla.invisionapp.com/share/HA254M642#/screens/61500963?maintainScrollPosition=false

note all those aren't consistent, but the major pieces are there. we can start with them.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Pull request

Lets start reviewing this. Darrin said he's happy to iterate on it in product for a bit, so this is just a start. It adds thumbnails to the tray (using a custom cell view and screenshots grabbed dynamically as we need them), and an animated transition.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8559366 [details] [review]
Pull request

I put lots of cleanup/refactoring comments in the PR, so I'd prefer to see a follow-up commit (or responses to the comments) before giving r+.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8559366 [details] [review]
Pull request

Updated the PR. I made the options argument super specific. Makes me a little sick inside, but I want to get this landed so that we can iterate with UX.

Also fixed the delay using a dispatch to the main thread.