1135768 - Make the tabs tray transition faster

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

I just guessed initially setting the tabs transition to 500ms. We should speed it up. We can also make those numbers a const so that all of our transitions can use them.

Comment 2

[Nick Alexander :nalexander [he/him]]

I am going to say that darrin's WIP tree at https://github.com/mozilla/firefox-ios/pull/230 fixes this ticket, since it shortens the tabs animation that wesj mentions from 0.5 seconds to 0.2 seconds.  (It does other things too, but let's call it that for convenience.)

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Github PR

I will take the review and landing of this ticket.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8579457 [details] [review]
Github PR

I landed this with some pretty major changes:

1) general style nits and clean up, including extracting TabTrayControllerUX struct of constants.

2) remove blur effect -- see comment.  It was popping terribly and fixing it would include adjusting the screenshot/view replacement, which I can't do now.

3) simplify the text layout -- see comment as well.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla/firefox-ios/commit/4de339c5aed2874028e66ad100b4467a1cfdb79d

Comment 6

[Nick Alexander :nalexander [he/him]]

kar: the tab tray animation speed was a significant concern from our early testing.  I think it's worth advertising that this has dropped the speed from 0.5 seconds to 0.2 seconds.

Comment 7

[Karen Rudnitski [:kar]]

Love it - thanks.