1129642 - [RTL][System] The blue triangle icon of all value selectors/drop down menus is rotated incorrectly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Blue Triangle icon

Description:
The blue triangle icon that can be found on all value selector/ drop down menus, like the one used to select languages, is rotated incorrectly.

Repro Steps:
1) Update a Flame to 20150204010225
2) Open Settings App> Languages
3) Choose Arabic and tap OK
4) observe blue triangle icon rotation


Actual:
The blue triangle icon is rotated incorrectly


Expected:
The blue triangle icon should be pointed into the bottom left corner

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150204010225
Gaia: dfebaaa8aab43470f482d09d71137bab840c3ae9
Gecko: 0c2f7434c325
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Repro frequency: 10/10
See attached: Screenshot

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 2.2

The blue triangle icon is rotated incorrectly

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150204002509
Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gecko: 8669c26fd4a5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Should we block 2.2 for this?

Comment 3

[Gregor Wagner [:gwagner]]

(In reply to Michael Henretty [:mhenretty] from comment #2)
> Should we block 2.2 for this?

Comment 4

[Stephany Wilkes]

Well that certainly is interesting. I think we should block on this. Thanks!

Comment 5

[Dylan Oliver [:doliver]]

RTL triage: P2, not actually blocking functionality but confusing UI.

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

Talking with Ahmed, this might be related to the Calendar patch that just landed in Bug 1059017.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Guillaume, please take a look.

Comment 8

[GitHub Autolander Bot]

Attachment: [PullReq] gmarty:Bug-1129642-RTL-blue-triangle-on-drop-down-menus to mozilla-b2g:master

Comment 9

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Kevin, can you take a look at this ultra small patch?

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8561942 [details] [review]
Github PR

Works well for me, thanks!

Comment 11

[Kevin Grandon :kgrandon]

Er, let's use the attachment from autolander next time in comment 8 :)


Manual landing in master: https://github.com/mozilla-b2g/gaia/commit/dfa6a912e36319a2232c7de2ccc3344f0e56e4d7

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8561942 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Slight papercut when viewing select boxes in RTL.
[Testing completed]: Manual testing (small css fix).
[Risk to taking this patch] (and alternatives if risky): One-liner css patch, very low risk.
[String changes made]: None.

Comment 13

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: Fixed screenshot

This issue is verified fixed on latest tinderbox central build. The blue triangle now points to the correct angle on drop down menus. See screenshot.

Tested on:
Device: Flame 3.0 Master (full flash 319MB mem)
BuildID: 20150210130358
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 14

[Pi Wei Cheng [:piwei] (inactive)]

Adding verifyme keyword for 2.2 verification.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/33b63ee6b718c5250a0615e1dadee97c9bead033

Comment 17

[Coler]

This issue has been verified successfully on Flame 2.2.
Reproduce rate:0/5
Attachment:Verify_RTL_Button.png

Flame 2.2 build:

Gaia-Rev        791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5dec207fcbeb
Build-ID        20150212002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150212.042208
FW-Date         Thu Feb 12 04:22:18 EST 2015
Bootloader      L1TC000118D0

Comment 18

[Coler]

Attachment: Verify_RTL_Button.png

Comment 19

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15887/