Closed Bug 1129642 Opened 9 years ago Closed 9 years ago

[RTL][System] The blue triangle icon of all value selectors/drop down menus is rotated incorrectly

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.2 S6 (20feb)
feature-b2g 2.2+
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: dharris, Assigned: gmarty)

References

Details

(Whiteboard: [3.0-Daily-Testing][systemsfe])

Attachments

(5 files)

Attached image Blue Triangle icon
Description:
The blue triangle icon that can be found on all value selector/ drop down menus, like the one used to select languages, is rotated incorrectly.

Repro Steps:
1) Update a Flame to 20150204010225
2) Open Settings App> Languages
3) Choose Arabic and tap OK
4) observe blue triangle icon rotation


Actual:
The blue triangle icon is rotated incorrectly


Expected:
The blue triangle icon should be pointed into the bottom left corner

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150204010225
Gaia: dfebaaa8aab43470f482d09d71137bab840c3ae9
Gecko: 0c2f7434c325
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Repro frequency: 10/10
See attached: Screenshot
This issue DOES occur on Flame 2.2

The blue triangle icon is rotated incorrectly

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150204002509
Gaia: a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gecko: 8669c26fd4a5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(pbylenga)
Should we block 2.2 for this?
blocking-b2g: --- → 2.2?
Whiteboard: [3.0-Daily-Testing] → [3.0-Daily-Testing][systemsfe]
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(pbylenga)
(In reply to Michael Henretty [:mhenretty] from comment #2)
> Should we block 2.2 for this?
Flags: needinfo?(swilkes)
Well that certainly is interesting. I think we should block on this. Thanks!
Flags: needinfo?(swilkes)
RTL triage: P2, not actually blocking functionality but confusing UI.
feature-b2g: --- → 2.2+
Priority: -- → P2
Talking with Ahmed, this might be related to the Calendar patch that just landed in Bug 1059017.
blocking-b2g: 2.2? → ---
Assignee: nobody → mhenretty
Target Milestone: --- → 2.2 S6 (20feb)
Guillaume, please take a look.
Assignee: mhenretty → gmarty
Attached file Github PR
Kevin, can you take a look at this ultra small patch?
Attachment #8561942 - Flags: review?(kgrandon)
Comment on attachment 8561942 [details] [review]
Github PR

Works well for me, thanks!
Attachment #8561942 - Flags: review?(kgrandon) → review+
Er, let's use the attachment from autolander next time in comment 8 :)


Manual landing in master: https://github.com/mozilla-b2g/gaia/commit/dfa6a912e36319a2232c7de2ccc3344f0e56e4d7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8561942 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Slight papercut when viewing select boxes in RTL.
[Testing completed]: Manual testing (small css fix).
[Risk to taking this patch] (and alternatives if risky): One-liner css patch, very low risk.
[String changes made]: None.
Attachment #8561942 - Flags: approval-gaia-v2.2?(bbajaj)
Attached image Fixed screenshot
This issue is verified fixed on latest tinderbox central build. The blue triangle now points to the correct angle on drop down menus. See screenshot.

Tested on:
Device: Flame 3.0 Master (full flash 319MB mem)
BuildID: 20150210130358
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Adding verifyme keyword for 2.2 verification.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][rtl-impact] → [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(ktucker)
Attachment #8561942 - Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
This issue has been verified successfully on Flame 2.2.
Reproduce rate:0/5
Attachment:Verify_RTL_Button.png

Flame 2.2 build:

Gaia-Rev        791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5dec207fcbeb
Build-ID        20150212002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150212.042208
FW-Date         Thu Feb 12 04:22:18 EST 2015
Bootloader      L1TC000118D0
QA Whiteboard: [QAnalyst-Triage+][rtl-impact] → [QAnalyst-Triage+][rtl-impact], [MGSEI-Triage+]
Keywords: verifyme
Attached image Verify_RTL_Button.png
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15887/
Flags: in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: