1129747 - Closure compiler breaks execution of the flowplayer

Status: RESOLVED INCOMPLETE

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

STR:

    1. git checkout e7b2d154725105
    2. grunt firefox
    3. install the extension, restart firefox
    4. open http://flash.flowplayer.org/plugins/streaming/rtmp.html
    5. notice "Error: assertion failed”
    6. edit extension/firefox/Makefile to use `BUNDLES_DIR = ../../build/bundles` at line 18
    7. repeat steps 2-4
    8. notice that there is no message as in step 5
    9. (cleanup: git checkout e7b2d154725105 -- extension/firefox/Makefile)
     

Actual result:
message in step 5 and failed execution of flowplay

Expected result:
no message in step 5 visible

Comment 1

[Yury Delendik (:yury)]

Okay, looks like it's just difference between release / non-release modes. For closure compiled code it's impossible to switch to release mode -- we are doing constants folding and by default release == false.

Fixed by https://github.com/mozilla/shumway/pull/2053

However original problem comes from https://github.com/mozilla/shumway/blob/6cd0f4596f30029f098ce96716b9d30b72d80c48/src/avm2/abc/parser.ts#L1643 `assert(factoryType && typeParameter);` check. Which comes from something undocumented https://github.com/mozilla/shumway/blob/6cd0f4596f30029f098ce96716b9d30b72d80c48/src/avm2/abc/parser.ts#L1069 - either factoryTypeIndex or typeParameterIndex equals 0. Michael, do you want to look at that?