Closure compiler breaks execution of the flowplayer

RESOLVED INCOMPLETE

Status

Firefox Graveyard
Shumway
RESOLVED INCOMPLETE
3 years ago
2 years ago

People

(Reporter: yury, Assigned: mbx)

Tracking

Trunk
x86
Mac OS X
Dependency tree / graph

Details

(Reporter)

Description

3 years ago
STR:

    1. git checkout e7b2d154725105
    2. grunt firefox
    3. install the extension, restart firefox
    4. open http://flash.flowplayer.org/plugins/streaming/rtmp.html
    5. notice "Error: assertion failed”
    6. edit extension/firefox/Makefile to use `BUNDLES_DIR = ../../build/bundles` at line 18
    7. repeat steps 2-4
    8. notice that there is no message as in step 5
    9. (cleanup: git checkout e7b2d154725105 -- extension/firefox/Makefile)
     

Actual result:
message in step 5 and failed execution of flowplay

Expected result:
no message in step 5 visible
(Reporter)

Comment 1

3 years ago
Okay, looks like it's just difference between release / non-release modes. For closure compiled code it's impossible to switch to release mode -- we are doing constants folding and by default release == false.

Fixed by https://github.com/mozilla/shumway/pull/2053

However original problem comes from https://github.com/mozilla/shumway/blob/6cd0f4596f30029f098ce96716b9d30b72d80c48/src/avm2/abc/parser.ts#L1643 `assert(factoryType && typeParameter);` check. Which comes from something undocumented https://github.com/mozilla/shumway/blob/6cd0f4596f30029f098ce96716b9d30b72d80c48/src/avm2/abc/parser.ts#L1069 - either factoryTypeIndex or typeParameterIndex equals 0. Michael, do you want to look at that?
Assignee: nobody → mbebenita
Blocks: 1120590
Flags: needinfo?(mbebenita)
No longer blocks: 1120590
Blocks: 1120590
Product: Firefox → Firefox Graveyard
(Assignee)

Updated

2 years ago
Flags: needinfo?(mbebenita)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.