1129831 - [FFOS2.0][Woodduck][GCF][STK]cause tag not fond on event download: browser termination

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[pengfei.huang]

DEFECT DESCRIPTION:[GCF][STK]cause tag not fond on event download: browser
termination

 REPRODUCING PROCEDURES:
1. Load a simcard to the phone which can send "eventlist: browser termination";
2. Execute TC 27.22.7.9.1/1, cause tag not fond on event download: browser
termination.--ko


 EXPECTED BEHAVIOUR:
2. Execute TC 27.22.7.9.1/1, cause tag should be ok on event download: browser
termination.

details please refer the log.


 ASSOCIATE SPECIFICATION:

 TEST PLAN REFERENCE:

 TOOLS AND PLATFORMS USED:

 USER IMPACT:

 REPRODUCING RATE:

 For FT PR, Please list reference mobile's behavior:

Comment 1

[pengfei.huang]

Attachment: Tag_missing.zip

Hi Mozilla,
  Per mail discuss, the envelope of "Browser Termination" event lack the tag "Browser Termination cause" which is mandatory. 
02-04 11:26:50.902   574   585 D use-Rlog/RLOG-AT: AT+STKENV="D60799010882028281"
  D6 ---> EVENT DOWNLOAD Tag
  07 ---> Length
  9901  --->Device identify
  0882028281   ---->Event List

Comment 2

[pengfei.huang]

  There are two type of cause defined in ril_const.
// Browser Termination Cause.
this.STK_BROWSER_TERMINATION_CAUSE_USER = 0x00;
this.STK_BROWSER_TERMINATION_CAUSE_ERROR = 0x01;
  
  and ril_worker has implemented the "Browser Termination cause" tag at sendICCEnvelopeCommand.
      GsmPDUHelper.writeHexOctet(options.terminationCause);

  Hence, we need to add options.terminationCause when send stkEventDownload. The problem is there is no related value for STK_BROWSER_TERMINATION_CAUSE_USER and STK_BROWSER_TERMINATION_CAUSE_ERROR at gaia. The other problem is how to confirm whether the browser is closed normally.
  Thanks.

Comment 3

[Josh Cheng [:josh]]

Hi Sean,
Could you please help to check the problem? Thanks!

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Reference:

@ETSI TS 102 223 V11.3.0 (2014-06)
7.5.9.2 Structure of ENVELOPE (EVENT DOWNLOAD - Browser termination)
8.51 Browser termination cause

00 = User Termination
01 = Error Termination

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Hi Pengfei,

Please try the trail patch. Thank you.

diff --git a/apps/system/js/icc_events.js b/apps/system/js/icc_events.js
index 88be40f..adf11cc 100644
--- a/apps/system/js/icc_events.js
+++ b/apps/system/js/icc_events.js
@@ -123,7 +123,8 @@ var icc_events = {
     function icc_events_handleBrowserTerminationEvent(message, evt) {
       DUMP(' STK Browser termination');
       this.downloadEvent(message, {
-        eventType: icc._iccManager.STK_EVENT_TYPE_BROWSER_TERMINATION
+        eventType: icc._iccManager.STK_EVENT_TYPE_BROWSER_TERMINATION,
+        terminationCause: icc._iccManager.STK_BROWSER_TERMINATION_CAUSE_USER
       });
   },

Comment 6

[pengfei.huang]

Hi Sean,
  Your patch works well. Pass the test.
  Thanks.

Comment 7

[GitHub Autolander Bot]

Attachment: [PullReq] weilonge:seanlee/STK/master/Bug1129831 to mozilla-b2g:master

Comment 8

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8560206 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1129831 to mozilla-b2g:master

Hello Fernando,

Here is my PR for this bug.
Could you help to review it?

Thank you.

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8560206 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1129831 to mozilla-b2g:master

r+ Thank you.

Could be great if we could detect a browser error, 404, 501, ... (STK_BROWSER_TERMINATION_CAUSE_ERROR) instead only user termination but not trivial now.

Comment 10

[GitHub Autolander Bot]

Attachment: [PullReq] weilonge:seanlee/STK/v2.0m/Bug1129831 to mozilla-b2g:v2.0m

Comment 11

[Sean Lee [:seanlee][:weilonge]]

landed on master : https://github.com/mozilla-b2g/gaia/commit/0e2c6dda49d0e6cd881ecaff13a5a72238f6e53b
landed on  v2.0m : https://github.com/mozilla-b2g/gaia/commit/999d5a9c082bc24e042357fcca201f9ca79955c8
      try-server : https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=7044e992a525

Comment 12

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8560206 [details] [review]
[PullReq] weilonge:seanlee/STK/master/Bug1129831 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):

[User impact] if declined:
The following spec is not implemented into our STK feature.
@ETSI TS 102 223 V11.3.0 (2014-06)
7.5.9.2 Structure of ENVELOPE (EVENT DOWNLOAD - Browser termination)
8.51 Browser termination cause

[Testing completed]:
Partner tested PASS in their LAB.

[Risk to taking this patch] (and alternatives if risky):
Only add one property to describe the cause of app termination.

[String changes made]:
None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d6f0e11446be7153f2717d2672463564775fec4c
v2.1: https://github.com/mozilla-b2g/gaia/commit/221e911a388916834d5da40190c52189b1676b21