1129835 - [Flame][Notifications]The time will skip to 2 minutes later after you unlock sreen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_1510.txt

[1.Description]:
According to 1112706 comment 39, this bug is filed.
[Flame 2.2 & 3.0][Notifications]After you drag down the utility tray, then drag up it and lock screen, unlock screen, wait for 1 minute, the time will skip to 2 mins later.
Found time:15:10
See attachment:1510.mp4 and logcat_1510.txt

[2.Testing Steps]: 
1. Enable the lockscreen.
2. Open the utility tray.
3. Start to slide up as if you wanted to close the utility tray.
4. While keeping your finger on the screen, press the power button.
5. Release your finger on screen and press the power button again.
6. Unlock device, wait for 1 minute, view the time at top-right.

[3.Expected Result]: 
6. The time should update immediately.

[4.Actual Result]: 
6. The time will skip to 2 minutes later(ex:15:09 -> 15:11).

[5.Reproduction build]: 
Flame 2.1 version:
Build ID               20150204002437
Gaia Revision          17bf14f12e43043654498330d610d469b8b55e64
Gaia Date              2015-02-03 05:19:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/bdebcc47ec7a
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.035620
Firmware Date          Wed Feb  4 03:56:31 EST 2015
Bootloader             L1TC000118D0

Flame 2.2 version:
Build ID               20150204002509
Gaia Revision          a4c4cc86303a554facb8f45b7e764e5c4473c3de
Gaia Date              2015-02-04 00:41:59
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8669c26fd4a5
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.035932
Firmware Date          Wed Feb  4 03:59:42 EST 2015
Bootloader             L1TC000118D0

Flame 3.0 version:
Build ID               20150204010225
Gaia Revision          dfebaaa8aab43470f482d09d71137bab840c3ae9
Gaia Date              2015-02-03 18:49:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0c2f7434c325
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.043856
Firmware Date          Wed Feb  4 04:39:07 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
occasionally Recurrence,3/5

[7.TCID]: 
Free Test

Comment 1

[Lance（leave from Mozilla）]

Attachment: 1510.MP4

Comment 2

[William Hsu [:whsu]]

Sometimes, status bar becomes out of sync.
Need to improve it.

Comment 3

[Gregor Wagner [:gwagner]]

Basic functionality.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Guillaume, will you take a look here?

Comment 5

[Guillaume Marty [:gmarty]]

I checked and I can reproduce 100% of times regardless of fiddling with the utility tray or not.
Locking/unlocking on master skip the first minute update.

I continue investigating this bug.

Comment 6

[GitHub Autolander Bot]

Attachment: [PullReq] gmarty:Bug-1129835-The-time-will-skip-to-2-minutes-later-after-you-unlock-screen to mozilla-b2g:master

Comment 7

[Guillaume Marty [:gmarty]]

Attachment: bug-rocketbar.png

From what I can tell, this bug was introduced by this commit:
https://github.com/mozilla-b2g/gaia/commit/4768a1c43a81408e5c7c8b77a9aff26f439bf7e5#diff-55cd9b725a69270f27ff6024bca7c3c7L56

Greg, can you tell me why you removed the call to `refresh` in `cl_setClockInterval`?

I created this PR to trigger the tests and see if anything goes wrong. Not asking for a r+ at this point.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Hmm...It's a long-ago patch so I don't remembered the actual reason. However it's indeed a mistake.

Comment 9

[Guillaume Marty [:gmarty]]

Comment on attachment 8561177 [details] [review]
[PullReq] gmarty:Bug-1129835-The-time-will-skip-to-2-minutes-later-after-you-unlock-screen to mozilla-b2g:master

Thanks Greg. All tests pass, so Etienne, can you take a look at this patch?

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8561177 [details] [review]
[PullReq] gmarty:Bug-1129835-The-time-will-skip-to-2-minutes-later-after-you-unlock-screen to mozilla-b2g:master

Forwarding to Greg who knows this code better.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8561177 [details] [review]
[PullReq] gmarty:Bug-1129835-The-time-will-skip-to-2-minutes-later-after-you-unlock-screen to mozilla-b2g:master

It's good. Let's correct the mistake, thanks.

Comment 12

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/ebe6e74d08935078086bd4617ff0fda31887a057

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Make sure you request uplift.

Comment 15

[Guillaume Marty [:gmarty]]

Comment on attachment 8561177 [details] [review]
[PullReq] gmarty:Bug-1129835-The-time-will-skip-to-2-minutes-later-after-you-unlock-screen to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Status bar
[User impact] if declined: After unlocking the screen, the first minute is not updated. One minute later, time is finally updated which results in the time skipping to 2 minutes later.
[Testing completed]: Manual testing required
[Risk to taking this patch] (and alternatives if risky): Very minimal patch
[String changes made]: None

Comment 16

[Lance（leave from Mozilla）]

The problem is verified not happen on latest Flame 3.0 build, but it still exist in latest Flame 2.2 build.

Steps:
1. Enable the lockscreen.
2. Open the utility tray.
3. Start to slide up as if you wanted to close the utility tray.
4. While keeping your finger on the screen, press the power button.
5. Release your finger on screen and press the power button again.
6. Unlock device, wait for 1 minute, view the time at top-right.

Expected Result: 
Flame 2.2: 6. The time should update immediately.

Actual Result: 
Flame 2.2: 6. The time will skip to 2 minutes later.
Flame 3.0: 6. The time will update immediately.

Fail rate:
Flame 2.2: 4/5
Flame 3.0: 0/5

Flame 2.2 version:
Build ID               20150215002504
Gaia Revision          ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gaia Date              2015-02-13 05:27:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/62c80c92b39e
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150215.040852
Firmware Date          Sun Feb 15 04:09:03 EST 2015
Bootloader             L1TC000118D0

Flame 3.0 version:
Build ID               20150215010209
Gaia Revision          f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gaia Date              2015-02-13 13:13:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e0cb32a0b1aa
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150215.043133
Firmware Date          Sun Feb 15 04:31:43 EST 2015
Bootloader             L1TC000118D0

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/3a14176f3f6bc7594ef80086eea14d8ad9d76f55

Comment 18

[Norry.L.F(Leave from Mozilla)]

Attachment: Verify_video.mp4

The problem is verified not happen on latest Flame 2.2 build.

Steps:
1. Enable the lockscreen.
2. Open the utility tray.
3. Start to slide up as if you wanted to close the utility tray.
4. While keeping your finger on the screen, press the power button.
5. Release your finger on screen and press the power button again.
6. Unlock device, wait for 1 minute, view the time at top-right.

Actual Result: 
6. The time will update immediately.

Fail rate:0/5
See attachment:Verify_video.MP4

Flame 2.2 version:
Build ID               20150225002505
Gaia Revision          ca64f2fe145909f31af266b1730874051ba76c78
Gaia Date              2015-02-24 22:06:53
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/16804008c29f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150225.041814
Firmware Date          Wed Feb 25 04:18:25 EST 2015
Bootloader             L1TC000118D0