Closed Bug 1130054 Opened 9 years ago Closed 9 years ago

Profiler module should remain active in e10s tests in perf++

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

37 Branch
x86
macOS
defect
Not set
normal

Tracking

(e10s+)

RESOLVED DUPLICATE of bug 1058898
Tracking Status
e10s + ---

People

(Reporter: jsantell, Unassigned)

References

Details

./mach mochitest-devtools browser/devtools/performance --e10s

2294 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-front-profiler-02.js | The built-in profiler module should still be active (1). - 
Stack trace:
    chrome://mochitests/content/browser/browser/devtools/performance/test/browser_perf-front-profiler-02.js:test<:21
    self-hosted:InterpretGeneratorResume:702
    self-hosted:next:610
    Tester_execTest@chrome://mochikit/content/browser-test.js:696:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:593:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
2295 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-front-profiler-02.js | The built-in profiler module should still be active (2). - 
Stack trace:
    chrome://mochitests/content/browser/browser/devtools/performance/test/browser_perf-front-profiler-02.js:test<:28
    self-hosted:InterpretGeneratorResume:702
    self-hosted:next:610
    Tester_execTest@chrome://mochikit/content/browser-test.js:696:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:593:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
2296 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-front-profiler-03.js | The built-in profiler module should still be active. - 
Stack trace:
    chrome://mochitests/content/browser/browser/devtools/performance/test/browser_perf-front-profiler-03.js:test<:25
    self-hosted:InterpretGeneratorResume:702
    self-hosted:next:610
    Tester_execTest@chrome://mochikit/content/browser-test.js:696:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:593:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
2297 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-front-profiler-04.js | The built-in profiler module should have been automatically stoped. - 
Stack trace:
    chrome://mochitests/content/browser/browser/devtools/performance/test/browser_perf-front-profiler-04.js:test<:39
    self-hosted:InterpretGeneratorResume:702
    self-hosted:next:610
    Tester_execTest@chrome://mochikit/content/browser-test.js:696:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:593:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
2298 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-shared-connection-03.js | The built-in profiler module should now be active. - 
Stack trace:
    chrome://mochitests/content/browser/browser/devtools/performance/test/browser_perf-shared-connection-03.js:spawnTest:18
    self-hosted:InterpretGeneratorResume:702
    self-hosted:next:660
    test@chrome://mochitests/content/browser/browser/devtools/performance/test/head.js:153:3
    Tester_execTest@chrome://mochikit/content/browser-test.js:696:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:593:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
2299 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-ui-recording.js | The built-in profiler module should now be active. - 
Stack trace:
    chrome://mochitests/content/browser/browser/devtools/performance/test/browser_perf-ui-recording.js:spawnTest:21
    self-hosted:InterpretGeneratorResume:702
    self-hosted:next:660
    test@chrome://mochitests/content/browser/browser/devtools/performance/test/head.js:153:3
    Tester_execTest@chrome://mochikit/content/browser-test.js:696:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:593:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
2300 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-ui-recording.js | The built-in profiler module should still be active. - 
Stack trace:
    chrome://mochitests/content/browser/browser/devtools/performance/test/browser_perf-ui-recording.js:spawnTest:26
    self-hosted:InterpretGeneratorResume:702
    self-hosted:next:660
    test@chrome://mochitests/content/browser/browser/devtools/performance/test/head.js:153:3
    Tester_execTest@chrome://mochikit/content/browser-test.js:696:9
    Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:593:7
    SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:752:59
SUITE-END | took 101s
All these tests in current profiler are skipped due to bug 1047124, which is closed anyways, but these are all skipped in both e10s and single-proc-mode.
Summary: profiler should remain active in e10s tests in perf++ → built-in profiler should remain active in e10s tests in perf++
After starting and stopping a recording session, `nsIProfilerModule.IsActive()` is false -- is this different in e10s? This also fails in the current profiler tests when removing the "skip" statements.
Think we're going to wait until we enable perf so there are no remenants of the previous profiler active.
No longer blocks: perf-tool-v2
Blocks: perf-tool-tests
No longer blocks: enable-perf-tool
Summary: built-in profiler should remain active in e10s tests in perf++ → Profiler module should remain active in e10s tests in perf++
Blocks: perf-tool-v2
No longer blocks: perf-tool-tests
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.